-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a _span string literal operator for creating constexpr CharSpans #30042
Merged
mergify
merged 3 commits into
project-chip:master
from
ksperling-apple:charspan-literal
Oct 28, 2023
Merged
Add a _span string literal operator for creating constexpr CharSpans #30042
mergify
merged 3 commits into
project-chip:master
from
ksperling-apple:charspan-literal
Oct 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
October 27, 2023 04:59
ksperling-apple
force-pushed
the
charspan-literal
branch
from
October 27, 2023 05:09
6cd789d
to
354f010
Compare
ksperling-apple
force-pushed
the
charspan-literal
branch
6 times, most recently
from
October 27, 2023 08:15
9d7e077
to
8b53c3e
Compare
ksperling-apple
changed the title
Add a _CharSpan string literal operator for creating constexpr CharSpans
Add a _span string literal operator for creating constexpr CharSpans
Oct 27, 2023
ksperling-apple
force-pushed
the
charspan-literal
branch
from
October 27, 2023 08:18
8b53c3e
to
6c82391
Compare
PR #30042: Size comparison from 02e7647 to 6c82391 Increases above 0.2%:
Increases (21 builds for bl702, bl702l, cc32xx, cyw30739, linux, psoc6)
Decreases (12 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 27, 2023
andy31415
approved these changes
Oct 27, 2023
PR #30042: Size comparison from 02e7647 to a391a32 Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…roject-chip#30042) * Add a _span string literal operator to create constexpr CharSpans * Adopt _span for literals * Tweaks from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows constexpr CharSpans to be created in a convenient way.