-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bouffalolab] Remove lwip in BL70X Thread Application #30020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wy-hh
commented
Oct 26, 2023
•
edited
Loading
edited
- Remove lwip in BL70X Thread Application
- Wi-Fi Application and Ethernet Application use lwip stack which is from Bouffalo Lab SDK
- Correct chip_data_model of BL702, Thread Application, to use lighting-app-thread.zap
- Update Implementation of BLConfig::Init to reduce the memory cost
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
electrocucaracha
October 26, 2023 12:06
pullapprove
bot
requested review from
vivien-apple,
yunhanw-google,
sharadb-amazon,
wiba-nordic,
tecimovic,
woody-apple,
tehampson,
younghak-hwang,
tima-q,
tobiasgraf,
yufengwangca and
turon
October 26, 2023 12:06
wy-hh
changed the title
[Bouffalolab] Remove lwip in Thread Application
[Bouffalolab] Remove lwip in BL70X Thread Application
Oct 26, 2023
PR #30020: Size comparison from 7f25fb2 to beab620 Increases above 0.2%:
Increases (7 builds for bl702, bl702l)
Decreases (10 builds for bl602, bl702, bl702l)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30020: Size comparison from 7f25fb2 to 40c74af Increases above 0.2%:
Increases (43 builds for bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, psoc6, telink)
Decreases (29 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, mbed, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 28, 2023
arkq
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.