-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match AdminCommissioningCluster
to spec
#30004
Merged
mergify
merged 3 commits into
project-chip:master
from
andy31415:admin_commissioning_to_spec
Oct 26, 2023
Merged
Match AdminCommissioningCluster
to spec
#30004
mergify
merged 3 commits into
project-chip:master
from
andy31415:admin_commissioning_to_spec
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
October 25, 2023 15:31
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 25, 2023 15:31
andy31415
added
the
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
label
Oct 25, 2023
PR #30004: Size comparison from c4148b0 to 1221fc0 Increases (8 builds for bl702, cc32xx, esp32, linux)
Decreases (2 builds for bl702l)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 25, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Changes to match spec * zap regen
andy31415
added
the
Spec XML align
SDK XML does not match the spec (including naming, etc)
label
Oct 31, 2023
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
fast track
review - pending
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Spec XML align
SDK XML does not match the spec (including naming, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
int16
. This is INT16U already so should not create binary incompatibilitesSpec does NOT define a name for status codes, so kept that enum.