Add TLV Parser #30
Merged
Add TLV Parser #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
robszewczyk,
tpmanley and
woody-apple
as code owners
woody-apple
approved these changes
Mar 10, 2020
gerickson
approved these changes
Mar 10, 2020
| -I$(TOP_DIR)/src/lib/ \ | ||
| -I$(TOP_DIR)/src/system \ | ||
| -I$(TOP_DIR)/build/config/standalone/ | ||
| -I. \ |
There was a problem hiding this comment.
can we avoid having tabs anywhere except explicitly required (i.e. in front of make commands)?
There was a problem hiding this comment.
Just as an example, what would you like this particular set of includes to look like?
There was a problem hiding this comment.
How about:
Includes=\
. \
$(TOP_DIR)/src \
$(TOP_DIR)/src/include \
$(TOP_DIR)/src/lib \
$(TOP_DIR)/src/system \
$(TOP_DIR)/build/config/standalone \
$(TOP_DIR)/third_party/nlio/repo/include \
$(TOP_DIR)/third_party/nlassert/repo/include
doublemis1
referenced
this pull request
in doublemis1/connectedhomeip
Jun 30, 2021
* Remove message lowercasing on rpc * Remove redundant code * Move the csg additions to above the main method, cannot forward declare the methods * Remove message lowercasing on rpc * Add debug prints and extra getpase command * Add get pase session * Initial PASE data fetch skeleton * Add separate csg folder to hold constants and utils * Add macros * GetPaseData should return a yaml str. * Add #defines, refactor into csg utilities, deserialize yaml * Fix linter, comments, add copyright * added get_pase_data RPC * refactor methods and variables * Add PASE Response parameters * Debuggin additions * Remove debugging additions * Fix RPC to allow none values * Remove pase from BLE call * Added response, pake 1,2,3 parameters * Remove merge artifact * Remove unnecessary edits * Add debug messages * Remove debug messages * Add todo Co-authored-by: Mikael H. Moeller <[email protected]>
doublemis1
referenced
this pull request
in doublemis1/connectedhomeip
Jul 7, 2021
* Remove message lowercasing on rpc * Remove redundant code * Move the csg additions to above the main method, cannot forward declare the methods * Remove message lowercasing on rpc * Add debug prints and extra getpase command * Add get pase session * Initial PASE data fetch skeleton * Add separate csg folder to hold constants and utils * Add macros * GetPaseData should return a yaml str. * Add #defines, refactor into csg utilities, deserialize yaml * Fix linter, comments, add copyright * added get_pase_data RPC * refactor methods and variables * Add PASE Response parameters * Debuggin additions * Remove debugging additions * Fix RPC to allow none values * Remove pase from BLE call * Added response, pake 1,2,3 parameters * Remove merge artifact * Remove unnecessary edits * Add debug messages * Remove debug messages * Add todo Co-authored-by: Mikael H. Moeller <[email protected]>
doublemis1
referenced
this pull request
in doublemis1/connectedhomeip
Jul 7, 2021
* Remove message lowercasing on rpc * Remove redundant code * Move the csg additions to above the main method, cannot forward declare the methods * Remove message lowercasing on rpc * Add debug prints and extra getpase command * Add get pase session * Initial PASE data fetch skeleton * Add separate csg folder to hold constants and utils * Add macros * GetPaseData should return a yaml str. * Add #defines, refactor into csg utilities, deserialize yaml * Fix linter, comments, add copyright * added get_pase_data RPC * refactor methods and variables * Add PASE Response parameters * Debuggin additions * Remove debugging additions * Fix RPC to allow none values * Remove pase from BLE call * Added response, pake 1,2,3 parameters * Remove merge artifact * Remove unnecessary edits * Add debug messages * Remove debug messages * Add todo Co-authored-by: Mikael H. Moeller <[email protected]>
doublemis1
referenced
this pull request
in doublemis1/connectedhomeip
Jul 26, 2021
* Add simple xml rpc server to chip device controller * Fix RPC Server address * Remove message lowercasing on rpc * Remove redundant code * Place all rpc, csg changes at the bottom of the file * Add todo comment * Add extra newlines * Move the csg additions to above the main method, cannot forward declare the methods * Open qr_code_parse to dict api for RPC server * Added development guide * Added Setup and Testing guide for Real and Virtual BLE Accessories * Updating Linux Lighting app docker file * demarcator added in setup_payload, new line at the end * Implemented Resolve method. * Code review comments resolved. * Implementation of ble-scan method with returning discovered devices (#18) * Implemented ble_scan with peripheral list return. * Update chip-device-ctrl.py * Implementation of ZCL AddNetwork and EnableNetwork methods (#23) RPC methods for Resolve and Zcl - AddNetwork and EnableNetwork implemented. * Add the test_client sample program * Updated Readme * Added new lines * Updated comments and readme * Updated README * Updated readme * Update chip-device-ctrl.py * Update chip-device-ctrl.py * Csg/feature/get pase data (#30) * Remove message lowercasing on rpc * Remove redundant code * Move the csg additions to above the main method, cannot forward declare the methods * Remove message lowercasing on rpc * Add debug prints and extra getpase command * Add get pase session * Initial PASE data fetch skeleton * Add separate csg folder to hold constants and utils * Add macros * GetPaseData should return a yaml str. * Add #defines, refactor into csg utilities, deserialize yaml * Fix linter, comments, add copyright * added get_pase_data RPC * refactor methods and variables * Add PASE Response parameters * Debuggin additions * Remove debugging additions * Fix RPC to allow none values * Remove pase from BLE call * Added response, pake 1,2,3 parameters * Remove merge artifact * Remove unnecessary edits * Add debug messages * Remove debug messages * Add todo Co-authored-by: Mikael H. Moeller <[email protected]> * Get fabric ID (#35) * Get fabric ID * Added Introspection for RPC methods (#39) * Added Introspection for RPC methods * Add pin code parsing * Update setup payload return * Remove extra spaces, extra newline * Rename to pin_code_parse * Add ble close * Add build_sdk only script * Remove extra space from argument assignment * Add new line at the end * Refactor test client build scripts * Add new line * Added resolve instruction and dockerfile fixes * Implement a generic cluster RPC call * Implement a generic cluster RPC call * removing unwanted comment * Addressing PR comments * Addressing PR review comments * correcting typing errors * Update chip-device-ctrl.py * Undo merge changes Co-authored-by: Xiaolei Zhou <[email protected]> Co-authored-by: SaileeG <[email protected]> Co-authored-by: Nirav Shah <[email protected]> Co-authored-by: Nirav Shah <[email protected]> Co-authored-by: Mikael H. Moeller <[email protected]> Co-authored-by: SaileeG <[email protected]> Co-authored-by: SaileeG <[email protected]>
doublemis1
referenced
this pull request
in doublemis1/connectedhomeip
Jul 26, 2021
* Remove message lowercasing on rpc * Remove redundant code * Move the csg additions to above the main method, cannot forward declare the methods * Remove message lowercasing on rpc * Add debug prints and extra getpase command * Add get pase session * Initial PASE data fetch skeleton * Add separate csg folder to hold constants and utils * Add macros * GetPaseData should return a yaml str. * Add #defines, refactor into csg utilities, deserialize yaml * Fix linter, comments, add copyright * added get_pase_data RPC * refactor methods and variables * Add PASE Response parameters * Debuggin additions * Remove debugging additions * Fix RPC to allow none values * Remove pase from BLE call * Added response, pake 1,2,3 parameters * Remove merge artifact * Remove unnecessary edits * Add debug messages * Remove debug messages * Add todo Co-authored-by: Mikael H. Moeller <[email protected]>
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought in the TLV Parser from open-Weave
@pan-apple @rwalker-apple @bhaskar-apple