-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDT v0.0.2 #29931
IDT v0.0.2 #29931
Conversation
commit 29d46b1 Author: bozowski <[email protected]> Date: Mon Oct 23 21:48:48 2023 -0700 Nit commit b432937 Author: bozowski <[email protected]> Date: Mon Oct 23 21:11:22 2023 -0700 README and error reporting and controlelr resturct commit 4ac762d Author: bozowski <[email protected]> Date: Mon Oct 23 19:15:59 2023 -0700 Logging commit 5b6b325 Author: bozowski <[email protected]> Date: Mon Oct 23 18:38:25 2023 -0700 Move logging commit 9df3206 Author: bozowski <[email protected]> Date: Mon Oct 23 18:13:57 2023 -0700 Prober commit 4683b34 Author: bozowski <[email protected]> Date: Mon Oct 23 17:55:03 2023 -0700 Make logcat resiliant commit 12bb816 Author: bozowski <[email protected]> Date: Mon Oct 23 17:30:37 2023 -0700 Warn when file is not growing commit 1451a02 Author: bozowski <[email protected]> Date: Mon Oct 23 16:03:36 2023 -0700 Real time analysis commit 8c8ac7f Author: bozowski <[email protected]> Date: Mon Oct 23 12:22:00 2023 -0700 Fix capabilities, screen commit 6ccfcc7 Author: bozowski <[email protected]> Date: Mon Oct 23 11:27:38 2023 -0700 Snoop commit 29d8969 Author: bozowski <[email protected]> Date: Mon Oct 23 11:12:26 2023 -0700 HCI logs commit a856bf6 Author: bozowski <[email protected]> Date: Fri Oct 20 15:04:32 2023 -0700 Fix pull commit 1239a90 Author: bozowski <[email protected]> Date: Fri Oct 20 14:51:22 2023 -0700 OK commit 2b3db4d Author: bozowski <[email protected]> Date: Fri Oct 20 14:09:16 2023 -0700 Screen recording commit 5d02aa6 Author: bozowski <[email protected]> Date: Fri Oct 20 13:34:05 2023 -0700 Nits commit 85517ff Author: bozowski <[email protected]> Date: Fri Oct 20 13:07:40 2023 -0700 Fix prober, color config commit c5d668c Author: bozowski <[email protected]> Date: Fri Oct 20 12:45:20 2023 -0700 Screen commit 6352581 Author: bozowski <[email protected]> Date: Thu Oct 19 21:39:05 2023 -0700 Nit commit 1c8a45a Author: bozowski <[email protected]> Date: Thu Oct 19 21:22:14 2023 -0700 Nit commit 51c187f Author: bozowski <[email protected]> Date: Thu Oct 19 21:10:07 2023 -0700 Splash commit 0091588 Author: bozowski <[email protected]> Date: Thu Oct 19 20:47:48 2023 -0700 Refactor commit c480a02 Author: bozowski <[email protected]> Date: Thu Oct 19 15:41:39 2023 -0700 Refactor commit 024eeb6 Author: bozowski <[email protected]> Date: Thu Oct 19 15:27:05 2023 -0700 Bugreport commit efcc621 Author: bozowski <[email protected]> Date: Thu Oct 19 14:51:30 2023 -0700 Nit commit d5474b7 Author: bozowski <[email protected]> Date: Thu Oct 19 14:33:18 2023 -0700 Configs commit 0fcbb10 Author: bozowski <[email protected]> Date: Thu Oct 19 04:26:54 2023 -0700 TODO commit b1c7a30 Author: bozowski <[email protected]> Date: Thu Oct 19 04:20:18 2023 -0700 Clean BUILD commit d86778a Author: bozowski <[email protected]> Date: Thu Oct 19 04:16:19 2023 -0700 Logging bug commit 6ebf7c0 Author: bozowski <[email protected]> Date: Thu Oct 19 03:03:48 2023 -0700 Branch
PR #29931: Size comparison from 7bcf5f0 to 51d41ec Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29931: Size comparison from 7bcf5f0 to 508e9c3 Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, psoc6)
Decreases (5 builds for esp32, nrfconnect, psoc6)
Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29931: Size comparison from 7bcf5f0 to 44a674f Increases above 0.2%:
Increases (26 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Multiproc seems to be a bit weird on the mac. TAL at if I can only use coro before un drafting. |
commit 36f3ceb Author: Austin Bozowski <[email protected]> Date: Wed Oct 25 20:07:16 2023 -0700 Multiproc to async and target macOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I definitely haven't made it to the bottom of this PR yet. Not even close. But I figured I'd throw down the comments I had so far. Meanwhile, I'm really struggling to differentiate what are the actual, substantive changes and additions vs fairly editorial stuff (print -> log ex) that are causing big diffs. Would you mind updating the PR description with all the changes we should be checking and where they're located?
src/tools/interop/idt/capture/ecosystem/play_services/play_services.py
Outdated
Show resolved
Hide resolved
src/tools/interop/idt/capture/ecosystem/play_services/play_services.py
Outdated
Show resolved
Hide resolved
src/tools/interop/idt/capture/ecosystem/play_services/play_services_analysis.py
Outdated
Show resolved
Hide resolved
src/tools/interop/idt/capture/ecosystem/play_services/play_services.py
Outdated
Show resolved
Hide resolved
src/tools/interop/idt/capture/platform/android/streams/screen/screen.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets commit and then iterate! LGTM
fast track based on review from @swan-amazon Foyer references can be kept .... maybe at some future followup we could split out some environment-specific configurations. |
Thank you so much everyone!!! |
Fixes #29477
Follow up from initial
idt
review and merge.The following requires consensus for the next iteration:
The following still need to be done:
Changes:
README
add more details of the project structureDockerfile
add dependencies to build tcpdump for arm 64.config
files throughout for helpful dev configs.probe
add structure for iteration and implement basic proberscapture
base
platform
split connect and start to separate steps, provide function to monitor streams (run_observers
).probe_capture
step toecosystem
(a probe step that runs after stop).controller
loader
fix coroutines validation.ecosystem
PlayServices
makeanalyze_capture
work in "real time", not just post analysis. Add foyer prober.PlayServicesUser
makeanalyze_capture
work in "real time", not just post analysis.platform
android
streams
logcat
adds monitor functionality that checks if device connection died or file is not growing; restarts as needed.pcap
try and run pcap on the android device; build and push tcpdump if possible and needed.screen
add monitor functionality and restart the stream as needed to account for three minute limit or disconnects.discovery
ble
Fix on the mac (instantiating scanner outside of coroutine only on mac causes crash... fixed) and document special settings requirement. Generally ensure all features work on macOS.dnssd
Write log. Parse all records and explain the content to the user.utils
compartmentalize and rename utils, move some functions.shell
make start uniform for sync and background command. Fix an issue with stdin going to background subproc interfering with sudo auth. Make killing subprocs more robust by accounting for sudo timeout in kill.log
centralize logging for standard format; colorize output to distinguish between program and subproc output and to make understanding log level easier for user feedback.idt
Verify non python dependencies before execution. Add splash for visual separation between runs.__main__
verify python version before further execution.