-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a device type metadata table in Darwin codegen. #29926
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:device-type-metadata
Oct 25, 2023
Merged
Add a device type metadata table in Darwin codegen. #29926
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:device-type-metadata
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29926: Size comparison from 0e67c82 to bdfd4f6 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 24, 2023
bdfd4f6
to
0b55c6b
Compare
PR #29926: Size comparison from 9ff8254 to 0b55c6b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
0b55c6b
to
775194b
Compare
PR #29926: Size comparison from 07d0417 to 775194b Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Oct 24, 2023
775194b
to
166d3e7
Compare
PR #29926: Size comparison from 0a37ad3 to 166d3e7 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The changes in device type XML were to clearly mark our test device types as having a test vendor id. The .zap files were updated with those new device type IDs, but this also has some noise in the .zap file, apparently.
166d3e7
to
f207f5e
Compare
PR #29926: Size comparison from 4823e34 to f207f5e Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Add a device type metadata table in Darwin codegen. The changes in device type XML were to clearly mark our test device types as having a test vendor id. The .zap files were updated with those new device type IDs, but this also has some noise in the .zap file, apparently. * Regenerate generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in device type XML were to clearly mark our test device types as
having a test vendor id. The .zap files were updated with those new device type
IDs, but this also has some noise in the .zap file, apparently.
The first changeset here is manual; the second one is just codegen.
This will fail CI until project-chip/zap#1180 merges and ZAP is updated.
Lays the groundwork for fixing #29270