-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Change default val of udpListenPort to 0 #29875
Merged
mergify
merged 1 commit into
project-chip:master
from
yhoyoon:feature/contribution-inet
Oct 20, 2023
Merged
[Android] Change default val of udpListenPort to 0 #29875
mergify
merged 1 commit into
project-chip:master
from
yhoyoon:feature/contribution-inet
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default value of the UDP listen port used in Android platform's ControllerParams from 5541 to 0. Since the default value of UDP listen port was 5541, if multiple matter applications using default settings are run on one matter device, UDP listen port conflict occurs. If we set the UDP listen port to 0, port collisions can be avoided because the port is bound randomly. Although matter applications can avoid conflicts by setting a UDP listen port, it is better to set this to its default value of 0 so that matter applications that use the default settings can avoid conflicts. Signed-off-by: Youngho Yoon <[email protected]> Signed-off-by: Charles Kim <[email protected]> Signed-off-by: Hunsup Jung <[email protected]> Signed-off-by: sanghyukko <[email protected]> Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Kyu-Wook Lim <[email protected]>
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
October 20, 2023 02:40
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
October 20, 2023 02:40
chulspro
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
PR #29875: Size comparison from 349b795 to 98375ba Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
JAEKILJEONG-SEC
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
andy31415
approved these changes
Oct 20, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
This commit changes the default value of the UDP listen port used in Android platform's ControllerParams from 5541 to 0. Since the default value of UDP listen port was 5541, if multiple matter applications using default settings are run on one matter device, UDP listen port conflict occurs. If we set the UDP listen port to 0, port collisions can be avoided because the port is bound randomly. Although matter applications can avoid conflicts by setting a UDP listen port, it is better to set this to its default value of 0 so that matter applications that use the default settings can avoid conflicts. Signed-off-by: Youngho Yoon <[email protected]> Signed-off-by: Charles Kim <[email protected]> Signed-off-by: Hunsup Jung <[email protected]> Signed-off-by: sanghyukko <[email protected]> Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Kyu-Wook Lim <[email protected]>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
This commit changes the default value of the UDP listen port used in Android platform's ControllerParams from 5541 to 0. Since the default value of UDP listen port was 5541, if multiple matter applications using default settings are run on one matter device, UDP listen port conflict occurs. If we set the UDP listen port to 0, port collisions can be avoided because the port is bound randomly. Although matter applications can avoid conflicts by setting a UDP listen port, it is better to set this to its default value of 0 so that matter applications that use the default settings can avoid conflicts. Signed-off-by: Youngho Yoon <[email protected]> Signed-off-by: Charles Kim <[email protected]> Signed-off-by: Hunsup Jung <[email protected]> Signed-off-by: sanghyukko <[email protected]> Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Kyu-Wook Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default value of the UDP listen port used in Android platform's ControllerParams from 5541 to 0. Since the default value of UDP listen port was 5541, if multiple matter applications using default settings are run on one matter device, UDP listen port conflict occurs. If we set the UDP listen port to 0, port collisions can be avoided because the port is bound randomly. Although matter applications can avoid conflicts by setting a UDP listen port, it is better to set this to its default value of 0 so that matter applications that use the default settings can avoid conflicts.