-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Air Purifier Example App #29861
Air Purifier Example App #29861
Conversation
… to merge bug fix from upstream, WIP
…rd-coded features for now
…ibuteChangeCallback to call that
needed for writing the percentSetting to percentCurrent
- set Min/max/ MeasuredValue - enable tolerance attribute
As a workaround save the KVS to NV when long pressing the right button. This can be used to save the state after e.g. a unpair.
@andy31415 Yeah, it is a bit odd. Ourselves and Bosch used this example on our Target Hardware for SVE, hence the inclusion of the PICs and the script for testing, as we thought it would help others. I will remove them to conform with the other examples though! (I don't know how to resolve your requested changes above, so have re-requested review, perhaps you can mark it resolved?) |
PR #29861: Size comparison from 2e5c2a7 to 55720a1 Increases (1 build for cc32xx)
Decreases (17 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
Full report (17 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
examples/air-purifier-app/air-purifier-common/src/air-purifier-manager.cpp
Outdated
Show resolved
Hide resolved
PR #29861: Size comparison from 2e5c2a7 to 054b61c Increases above 0.2%:
Increases (28 builds for bl602, bl702, bl702l, cc32xx, linux, psoc6)
Decreases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This reverts commit 894a129.
… air purifier example readme file
PR #29861: Size comparison from 2e5c2a7 to 20f0455 Increases above 0.2%:
Increases (39 builds for bl602, bl702, bl702l, cc32xx, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Adding Air Purifier example framework and basic app, WIP * wip, started adding class structures * A messy yet stable version of the air-purifier, doesn't build as need to merge bug fix from upstream, WIP * Added TODO and tested following merge * The Air Quality Cluster API changed so updated constructor to take hard-coded features for now * Added common device callback interface and changed the MatterPostAttributeChangeCallback to call that * Changed the way we initialise the singleton Air Purifier Manager * Add air-purifier example for Ameba platform * Fixed wrong cluster revision in zap for concentraitons * Add air-purifier example for CC32xx platform * Add LastChangedTime and ReplaceableProductList To zap For HEPAFREMON And ACFREMON * Updates to zap file for missing attributes and commands * Adding PICS for the example * Add PostchangeCallback To CC32XX Example needed for writing the percentSetting to percentCurrent * Fix Zap File for RH - set Min/max/ MeasuredValue - enable tolerance attribute * Fix Zap File For Temp Measurement * Update ClusterRev For Thermostat From 5 To 6 * Update FeatureMap For Fan Control * Regenerate Matter File From Previous Zap Changes * Add Button Handler For CC32XX As a workaround save the KVS to NV when long pressing the right button. This can be used to save the state after e.g. a unpair. * Use Common filter-delegates.cpp For CC32XX Example * Switched thermostat pics to be AbsLimits on the setpoint * Updated the zapfile for thermostat * Adding thermostat manager * Changed all temperatures to be *100 and added callthrough from top level manager to thermostat when handling attribute changes * Added thermostat endpoint into init call * Changed name of attribute write handlers * Changed name of attribute write handlers * Add Thermostat-manager To CC32XX example * Add helper script for executing Air-Purifier tests * Remove duplicate line in air-purifier test runner script * Adding CHIP header comment to files * Removing Thermostat as the tests are broken for our use case * Removing TSTAT tests * Adding PICS folder in common with XML and simple PICS * Add Correct Device Type And Name * Removing Thermostat as the tests are broken for our use case * Add A Way To Reset The Matter Part Of The Device For CC32XX Air Purifier Example App this just deletes the kvs.cfg file on long pressing SW3 * Update README * Remove Commented Code * Update Copyright For CC32xx To 2023 * Update Copyright to 2023 For Ameba * Regenned after merging upstream * Added clearer Fan Mode support and some comments * Added comment re: TODO for thermostat endpoint * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Restyled by prettier-markdown * Restyled by shellharden * Removed missing reference in cc32xx readme * Adding README for linux and adding all README's to the docs toctree * Attempt 2 at setting toctree for new readmes * Fix whitespace in script * Restyled by shfmt * Fixed spelling mistake in Readme * Update include paths * Add Ameba air-purifier example readme file * Add words to wordlist * Removed PICS and script, changed cc32xx headers to use pragma once * Restyled by clang-format * Restyled by prettier-markdown * Removed TODO's from common code as they were not relevant * Revert "Add words to wordlist" This reverts commit 894a129. * Replace indentations with fenced code blocks and minor tidy up within air purifier example readme file * Removed old debug comments from gn file * Added linux air-purifier-app to the helper script for building examples * Added air-purifier example for linux to CI * Restyled by prettier-markdown --------- Co-authored-by: Chris Mapp <[email protected]> Co-authored-by: Graf Tobias <[email protected]> Co-authored-by: Restyled.io <[email protected]>
This PR adds an Air Purifier Example App for
linux
,ameba
&cc32xx
.This is a composed device:
I will add a Thermostat on EP5 in a future PR.