-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove door lock cluster from all-clusters-app #29802
Merged
mergify
merged 8 commits into
project-chip:master
from
cecille:remove_door_lock_from_all_clusters
Oct 24, 2023
Merged
Remove door lock cluster from all-clusters-app #29802
mergify
merged 8 commits into
project-chip:master
from
cecille:remove_door_lock_from_all_clusters
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both QA and the CI are using the door-lock app for all testing of the door lock cluster. The all-clusters version is not well tested, and is missing some command handlers. Removing this in all-clusters in favour of the door lock app so we don't have to maintain it in two places and to save some space.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
October 16, 2023 21:47
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca,
turon,
yunhanw-google,
vivien-apple,
wiba-nordic and
woody-apple
October 16, 2023 21:47
PR #29802: Size comparison from 462c79a to e266583 Increases (1 build for psoc6)
Decreases (3 builds for linux, psoc6)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Oct 17, 2023
mkardous-silabs
approved these changes
Oct 17, 2023
PR #29802: Size comparison from 462c79a to f593b81 Increases above 0.2%:
Increases (19 builds for bl702l, cc32xx, linux, psoc6, telink)
Decreases (7 builds for linux, nrfconnect, psoc6, telink)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Oct 17, 2023
yufengwangca
approved these changes
Oct 18, 2023
Tagging @cecille for a conflict here. |
woody-apple
approved these changes
Oct 24, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Remove door lock cluster from all-clusters-app Both QA and the CI are using the door-lock app for all testing of the door lock cluster. The all-clusters version is not well tested, and is missing some command handlers. Removing this in all-clusters in favour of the door lock app so we don't have to maintain it in two places and to save some space. * Fix esp32 build file * Remove door lock support for esp32 * Remove door lock support from telink * Remove door lock support for nrfconnect * Fix esp32 compilation * Restyle --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both QA and the CI are using the door-lock app for all testing of the door lock cluster. The all-clusters version is not well tested, and is missing some command handlers.
Removing this in all-clusters in favour of the door lock app so we don't have to maintain it in two places and to save some space.