-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Move nameindex implementation #29775
[Android] Move nameindex implementation #29775
Conversation
PR #29775: Size comparison from e6f0134 to 81b8aa1 Increases (18 builds for cc32xx, linux, psoc6)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29775: Size comparison from e6f0134 to fee49fc Increases (18 builds for cc32xx, linux, psoc6)
Decreases (1 build for bl602)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Typically, we don't append the "Default" postfix to the command implementation in the src/inet/InetInterfaceImplDefault.cpp file. Instead, we implement files with the same names under src/platform// to override the default implementation. |
fee49fc
to
fb4e22a
Compare
PR #29775: Size comparison from 462c79a to fb4e22a Increases (18 builds for cc32xx, linux, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #29775: Size comparison from 462c79a to 7a8f1c6 Increases (19 builds for cc32xx, linux, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Move android nameindex implementation * Restyled by whitespace * Restyled by clang-format * fix build error in other platform * Fix darwin build error * Update src/inet/InetInterfaceImpl.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Fixes #29483