Stop using CHIPClusters in core code and chip-tool. #29772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #29772: Size comparison from 4507eda to d849635 Decreases (35 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Oct 14, 2023
They are not really needed; we should really stop generating them.
bzbarsky-apple
force-pushed
the
stop-using-CHIPClusters-in-core
branch
from
d849635 to
6cde056
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
|
PR #29772: Size comparison from eac0c7c to 6cde056 Increases (10 builds for bl702, bl702l, psoc6)
Decreases (35 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 16, 2023
markus-becker-tridonic-com
added a commit
to markus-becker-tridonic-com/connectedhomeip
that referenced
this pull request
Oct 19, 2023
Python lighting-app was broken (see project-chip#29508) and got fixed in project-chip#29772. Let's make sure that it does not break again by compiling it in CI. Signed-off-by: Markus Becker <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Python lighting-app was broken (see #29508) and got fixed in #29772. Let's make sure that it does not break again by compiling it in CI. Signed-off-by: Markus Becker <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
They are not really needed; we should really stop generating them.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Python lighting-app was broken (see project-chip#29508) and got fixed in project-chip#29772. Let's make sure that it does not break again by compiling it in CI. Signed-off-by: Markus Becker <[email protected]>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
Python lighting-app was broken (see project-chip#29508) and got fixed in project-chip#29772. Let's make sure that it does not break again by compiling it in CI. Signed-off-by: Markus Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not really needed; we should really stop generating them.