-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enums that are not used as a type in XML can now suppress codegen intended for DataModel::Decode #29739
Merged
tehampson
merged 5 commits into
project-chip:master
from
tehampson:modebase-enum-cleanup
Oct 13, 2023
Merged
Enums that are not used as a type in XML can now suppress codegen intended for DataModel::Decode #29739
tehampson
merged 5 commits into
project-chip:master
from
tehampson:modebase-enum-cleanup
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29739: Size comparison from f900f46 to 888a865 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
October 12, 2023 19:23
pullapprove
bot
requested review from
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
October 12, 2023 19:23
tcarmelveilleux
approved these changes
Oct 12, 2023
PR #29739: Size comparison from f900f46 to 0a58760 Increases (4 builds for psoc6)
Decreases (1 build for cc32xx)
Full report (27 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29739: Size comparison from f900f46 to 7cd9038 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
PR #29739: Size comparison from f900f46 to eb0794c Increases (7 builds for bl702, bl702l, psoc6)
Decreases (5 builds for bl702, cc32xx)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Oct 12, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
PR #29739: Size comparison from f900f46 to 2425575 Increases above 0.2%:
Increases (27 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, psoc6)
Decreases (37 builds for bl702, bl702l, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
changed the title
Allow for enums that are not used in a DataModel struct to be generat…
Enums that are not used as a type in XML can no suppress codegen intended for DataModel::Decode
Oct 13, 2023
tehampson
changed the title
Enums that are not used as a type in XML can no suppress codegen intended for DataModel::Decode
Enums that are not used as a type in XML can now suppress codegen intended for DataModel::Decode
Oct 13, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…for DataModel::Decode (project-chip#29739) Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial mitigation for #29693
Problem:
In the derived ModeBase cluster (such as RvcRunMode) the enumerated DerivedClusterTags and DerivedClusterCodes contains an kUnknownEnumValue of 0 that overlap with CommonTag,CommonCode from ModeBase.
Test: