-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Cleanup zap for name support #29712
Merged
mergify
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:feature/cleanup_zap_scene_name
Nov 1, 2023
Merged
[Scenes] Cleanup zap for name support #29712
mergify
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:feature/cleanup_zap_scene_name
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13 and
harsha-rajendran
October 11, 2023 19:15
lpbeliveau-silabs
force-pushed
the
feature/cleanup_zap_scene_name
branch
from
October 13, 2023 15:33
3c90a22
to
a620dde
Compare
PR #29712: Size comparison from 2bd1e1b to a620dde Increases (27 builds for bl702, bl702l, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Oct 17, 2023
lpbeliveau-silabs
force-pushed
the
feature/cleanup_zap_scene_name
branch
3 times, most recently
from
October 27, 2023 15:50
0264270
to
2a1122c
Compare
lpbeliveau-silabs
force-pushed
the
feature/cleanup_zap_scene_name
branch
2 times, most recently
from
October 27, 2023 16:12
72aac96
to
5bf9002
Compare
PR #29712: Size comparison from 02e7647 to 5bf9002 Increases (14 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (10 builds for bl702, bl702l, cc32xx, linux, psoc6)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
lpbeliveau-silabs
force-pushed
the
feature/cleanup_zap_scene_name
branch
from
October 27, 2023 17:22
5bf9002
to
bfae161
Compare
PR #29712: Size comparison from 367c28e to bfae161 Increases (20 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6)
Decreases (11 builds for bl702, cc32xx, esp32, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Oct 28, 2023
PR #29712: Size comparison from 367c28e to ce23f94 Increases above 0.2%:
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 30, 2023
PR #29712: Size comparison from 5c9d8e8 to 667d88b Increases (5 builds for cc32xx, nrfconnect)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #29712: Size comparison from 5c9d8e8 to b8a69b4 Increases (28 builds for bl702, bl702l, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29712: Size comparison from 07309d5 to cc7825b Increases (28 builds for bl702, bl702l, cc32xx, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
examples
review - approved
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused parameters in gen_config.zapt and added Bitmap for NameSupport attribute in the Scenes cluster