-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android]Remove unnecessary globalRef for android IM JNI #29710
Merged
mergify
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/follow-up-29236
Oct 16, 2023
Merged
[Android]Remove unnecessary globalRef for android IM JNI #29710
mergify
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/follow-up-29236
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
October 11, 2023 18:29
robszewczyk
reviewed
Oct 12, 2023
yunhanw-google
force-pushed
the
feature/follow-up-29236
branch
from
October 12, 2023 22:22
bb122fd
to
099b2f1
Compare
PR #29710: Size comparison from 47836d2 to 099b2f1 Decreases (1 build for bl602)
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
force-pushed
the
feature/follow-up-29236
branch
2 times, most recently
from
October 13, 2023 02:11
c3cd31b
to
a16c105
Compare
PR #29710: Size comparison from 85b54cd to a16c105 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yunhanw-google
force-pushed
the
feature/follow-up-29236
branch
2 times, most recently
from
October 14, 2023 06:01
2b59156
to
78f382c
Compare
PR #29710: Size comparison from eac0c7c to 78f382c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
localReferences created by sdk's local functions has not yet been removed and are still valid, so there is no need to create globalRef when it is returned from local functions.
yunhanw-google
force-pushed
the
feature/follow-up-29236
branch
from
October 14, 2023 14:11
78f382c
to
a955be8
Compare
PR #29710: Size comparison from eac0c7c to 3bc89f6 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
robszewczyk
approved these changes
Oct 16, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…p#29710) * Remove unnecessary globalRef for android im functions localReferences created by sdk's local functions has not yet been removed and are still valid, so there is no need to create globalRef when it is returned from local functions. * Restyled by clang-format * add JniGlobalReference class with move constructor * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localReferences created by sdk's local callback functions are still valid after returned, and managed by default jni frame/cookie, so there is no need to create globalRef to extend lifetime for the references when it is returned from local functions. Further We have used push/pop local frame in previous pr 29236, where localReferenced created in local callback function are managed by local jni frame.
Add JniGlobalReference class to handle the global reference creation/move/destory.
Address the rest of comments from 29236.