Impove CD validation

[robszewczyk]

We currently peform validation against PAA checks in encoding. In decoding, we check for cryptographic validity, but do not perform the same checks againts the data. This commit brings the encoding and decoding into parity.

[github-actions]

PR #29664: Size comparison from 3dfffe7 to 2427722

Full report (27 builds for cyw30739, linux, mbed, nrfconnect, psoc6, qpg)

platform	target	config	section	3dfffe7	2427722	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	551543	551543	0	0.0
			.app_xip_area	442745	442745	0	0.0
			.bss	63768	63768	0	0.0
			.data	660	660	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	537695	537695	0	0.0
			.app_xip_area	424105	424105	0	0.0
			.bss	68536	68536	0	0.0
			.data	688	688	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor	cyw930739m2evb_01	(read/write)	573639	573639	0	0.0
			.app_xip_area	466169	466169	0	0.0
			.bss	62512	62512	0	0.0
			.data	588	588	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	switch	cyw930739m2evb_01	(read/write)	549463	549463	0	0.0
			.app_xip_area	438897	438897	0	0.0
			.bss	65512	65512	0	0.0
			.data	684	684	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
linux	all-clusters-app	debug	(read only)	5494097	5494097	0	0.0
			(read/write)	420552	420552	0	0.0
			.bss	130480	130480	0	0.0
			.data	3856	3856	0	0.0
			.data.rel.ro	278848	278848	0	0.0
			.dynamic	624	624	0	0.0
			.got	5384	5384	0	0.0
			.init	27	27	0	0.0
			.init_array	1328	1328	0	0.0
			.rodata	335468	335468	0	0.0
			.text	4777811	4777811	0	0.0
	all-clusters-minimal-app	debug	(read only)	4873929	4873929	0	0.0
			(read/write)	232688	232688	0	0.0
			.bss	126512	126512	0	0.0
			.data	3760	3760	0	0.0
			.data.rel.ro	95280	95280	0	0.0
			.dynamic	624	624	0	0.0
			.got	5344	5344	0	0.0
			.init	27	27	0	0.0
			.init_array	1144	1144	0	0.0
			.rodata	270365	270365	0	0.0
			.text	4372451	4372451	0	0.0
	bridge-app	debug	(read only)	2752905	2752905	0	0.0
			(read/write)	133168	133168	0	0.0
			.bss	51736	51736	0	0.0
			.data	3680	3680	0	0.0
			.data.rel.ro	71648	71648	0	0.0
			.dynamic	624	624	0	0.0
			.got	4640	4640	0	0.0
			.init	27	27	0	0.0
			.init_array	816	816	0	0.0
			.rodata	213280	213280	0	0.0
			.text	2361859	2361859	0	0.0
	chip-tool	debug	(read only)	10208233	10208233	0	0.0
			(read/write)	443032	443032	0	0.0
			.bss	93688	93688	0	0.0
			.data	4994	4994	0	0.0
			.data.rel.ro	337104	337104	0	0.0
			.dynamic	624	624	0	0.0
			.got	5808	5808	0	0.0
			.init	27	27	0	0.0
			.init_array	760	760	0	0.0
			.rodata	386185	386185	0	0.0
			.text	9225027	9225027	0	0.0
	chip-tool-ipv6only	arm64	(read only)	10077996	10077996	0	0.0
			(read/write)	504792	504792	0	0.0
			.bss	103032	103032	0	0.0
			.data	4288	4288	0	0.0
			.data.rel.ro	373648	373648	0	0.0
			.dynamic	512	512	0	0.0
			.got	18368	18368	0	0.0
			.init	24	24	0	0.0
			.init_array	248	248	0	0.0
			.rodata	314888	314888	0	0.0
			.text	8997576	8997576	0	0.0
	lighting-app	debug+rpc+ui	(read only)	5213041	5213041	0	0.0
			(read/write)	222856	222856	0	0.0
			.bss	118160	118160	0	0.0
			.data	4416	4416	0	0.0
			.data.rel.ro	92704	92704	0	0.0
			.dynamic	672	672	0	0.0
			.got	5928	5928	0	0.0
			.init	27	27	0	0.0
			.init_array	944	944	0	0.0
			.rodata	336244	336244	0	0.0
			.text	4633907	4633907	0	0.0
	lock-app	debug	(read only)	4450433	4450433	0	0.0
			(read/write)	203128	203128	0	0.0
			.bss	113424	113424	0	0.0
			.data	3648	3648	0	0.0
			.data.rel.ro	79288	79288	0	0.0
			.dynamic	624	624	0	0.0
			.got	5264	5264	0	0.0
			.init	27	27	0	0.0
			.init_array	864	864	0	0.0
			.rodata	246813	246813	0	0.0
			.text	3994003	3994003	0	0.0
	ota-provider-app	debug	(read only)	4116465	4116465	0	0.0
			(read/write)	192064	192064	0	0.0
			.bss	113568	113568	0	0.0
			.data	3920	3920	0	0.0
			.data.rel.ro	68656	68656	0	0.0
			.dynamic	624	624	0	0.0
			.got	4544	4544	0	0.0
			.init	27	27	0	0.0
			.init_array	728	728	0	0.0
			.rodata	200061	200061	0	0.0
			.text	3725843	3725843	0	0.0
	ota-requestor-app	debug	(read only)	4201865	4201865	0	0.0
			(read/write)	196280	196280	0	0.0
			.bss	114592	114592	0	0.0
			.data	4160	4160	0	0.0
			.data.rel.ro	71632	71632	0	0.0
			.dynamic	624	624	0	0.0
			.got	4480	4480	0	0.0
			.init	27	27	0	0.0
			.init_array	784	784	0	0.0
			.rodata	203293	203293	0	0.0
			.text	3803683	3803683	0	0.0
	shell	debug	(read only)	2899921	2899921	0	0.0
			(read/write)	153248	153248	0	0.0
			.bss	61000	61000	0	0.0
			.data	784	784	0	0.0
			.data.rel.ro	85544	85544	0	0.0
			.dynamic	592	592	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	1168	1168	0	0.0
			.rodata	211200	211200	0	0.0
			.text	2515282	2515282	0	0.0
	thermostat-no-ble	arm64	(read only)	4345388	4345388	0	0.0
			(read/write)	241832	241832	0	0.0
			.bss	122168	122168	0	0.0
			.data	2792	2792	0	0.0
			.data.rel.ro	100528	100528	0	0.0
			.dynamic	512	512	0	0.0
			.got	11896	11896	0	0.0
			.init	24	24	0	0.0
			.init_array	424	424	0	0.0
			.rodata	161052	161052	0	0.0
			.text	3849784	3849784	0	0.0
	tv-app	debug	(read only)	5276897	5276897	0	0.0
			(read/write)	350696	350696	0	0.0
			.bss	241888	241888	0	0.0
			.data	5024	5024	0	0.0
			.data.rel.ro	96384	96384	0	0.0
			.dynamic	624	624	0	0.0
			.got	5608	5608	0	0.0
			.init	27	27	0	0.0
			.init_array	1152	1152	0	0.0
			.rodata	271117	271117	0	0.0
			.text	4761699	4761699	0	0.0
	tv-casting-app	debug	(read only)	8138801	8138801	0	0.0
			(read/write)	312872	312872	0	0.0
			.bss	155904	155904	0	0.0
			.data	2464	2464	0	0.0
			.data.rel.ro	147696	147696	0	0.0
			.dynamic	624	624	0	0.0
			.got	5080	5080	0	0.0
			.init	27	27	0	0.0
			.init_array	1088	1088	0	0.0
			.rodata	336152	336152	0	0.0
			.text	7401155	7401155	0	0.0
mbed	lock-app-release	cy8cproto_062_4343w	(read only)	6224	6224	0	0.0
			(read/write)	2521784	2521784	0	0.0
			.bss	219064	219064	0	0.0
			.data	5128	5128	0	0.0
			.text	1484468	1484468	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1227632	1227632	0	0.0
			bss	154518	154518	0	0.0
			rodata	142644	142644	0	0.0
			text	851436	851436	0	0.0
		nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1347252	1347252	0	0.0
			bss	140528	140528	0	0.0
			rodata	136880	136880	0	0.0
			text	779164	779164	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1159984	1159984	0	0.0
			bss	153948	153948	0	0.0
			rodata	113668	113668	0	0.0
			text	813428	813428	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	(read only)	837512	837512	0	0.0
			(read/write)	1778276	1778276	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	193300	193300	0	0.0
			.comment	212	212	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2528	2528	0	0.0
			.debug_abbrev	1379668	1379668	0	0.0
			.debug_aranges	145560	145560	0	0.0
			.debug_frame	482748	482748	0	0.0
			.debug_info	32217946	32217946	0	0.0
			.debug_line	4041155	4041155	0	0.0
			.debug_line_str	957	957	0	0.0
			.debug_loclists	2317074	2317074	0	0.0
			.debug_rnglists	155929	155929	0	0.0
			.debug_str	4182976	4182976	0	0.0
			.heap	837512	837512	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	296	296	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	844211	844211	0	0.0
			.symtab	513744	513744	0	0.0
			.text	1574060	1574060	0	0.0
			.zero.table	8	8	0	0.0
			text	0	0	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	(read only)	840168	840168	0	0.0
			(read/write)	1680756	1680756	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	190708	190708	0	0.0
			.comment	212	212	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2464	2464	0	0.0
			.debug_abbrev	1260663	1260663	0	0.0
			.debug_aranges	137360	137360	0	0.0
			.debug_frame	461176	461176	0	0.0
			.debug_info	28558392	28558392	0	0.0
			.debug_line	3800306	3800306	0	0.0
			.debug_line_str	981	981	0	0.0
			.debug_loclists	2190449	2190449	0	0.0
			.debug_rnglists	147496	147496	0	0.0
			.debug_str	3984616	3984616	0	0.0
			.heap	840168	840168	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	296	296	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	741027	741027	0	0.0
			.symtab	474560	474560	0	0.0
			.text	1479196	1479196	0	0.0
			.zero.table	0	0	0	0.0
				8	8	0	0.0
	light	cy8ckit_062s2_43012	(read only)	846496	846496	0	0.0
			(read/write)	1607164	1607164	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	184492	184492	0	0.0
			.comment	212	212	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2352	2352	0	0.0
			.debug_abbrev	1101635	1101635	0	0.0
			.debug_aranges	127424	127424	0	0.0
			.debug_frame	424108	424108	0	0.0
			.debug_info	23679722	23679722	0	0.0
			.debug_line	3375088	3375088	0	0.0
			.debug_line_str	942	942	0	0.0
			.debug_loclists	2027173	2027173	0	0.0
			.debug_rnglists	137048	137048	0	0.0
			.debug_str	3791698	3791698	0	0.0
			.heap	846496	846496	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	296	296	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	654119	654119	0	0.0
			.symtab	436016	436016	0	0.0
			.text	1411932	1411932	0	0.0
			.zero.table	0	0	0	0.0
				8	8	0	0.0
	lock	cy8ckit_062s2_43012	(read only)	819232	819232	0	0.0
			(read/write)	1640172	1640172	0	0.0
			.ARM.attributes	46	46	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	211740	211740	0	0.0
			.comment	212	212	0	0.0
			.copy.table	24	24	0	0.0
			.cy_m0p_image	6216	6216	0	0.0
			.cy_sharedmem	8	8	0	0.0
			.data	2368	2368	0	0.0
			.debug_abbrev	1093826	1093826	0	0.0
			.debug_aranges	126056	126056	0	0.0
			.debug_frame	419132	419132	0	0.0
			.debug_info	23482990	23482990	0	0.0
			.debug_line	3325670	3325670	0	0.0
			.debug_line_str	933	933	0	0.0
			.debug_loclists	2002659	2002659	0	0.0
			.debug_rnglists	134989	134989	0	0.0
			.debug_str	3753688	3753688	0	0.0
			.heap	819232	819232	0	0.0
			.noinit	148	148	0	0.0
			.ramVectors	736	736	0	0.0
			.shstrtab	296	296	0	0.0
			.stack_dummy	4096	4096	0	0.0
			.strtab	627663	627663	0	0.0
			.symtab	427600	427600	0	0.0
			.text	1417676	1417676	0	0.0
			.zero.table	0	0	0	0.0
				8	8	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1175536	1175536	0	0.0
			.bss	100616	100616	0	0.0
			.data	740	740	0	0.0
			.text	622376	622376	0	0.0
	lock-app	qpg6105+debug	(read/write)	1132328	1132328	0	0.0
			.bss	95320	95320	0	0.0
			.data	744	744	0	0.0
			.text	579172	579172	0	0.0