-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[external buildsystem] scripts/configure: allow out-of-tree project root #29627
Merged
mergify
merged 1 commit into
project-chip:master
from
plan44:PR/scripts-configure-allow-out-of-tree-project-root
Oct 10, 2023
Merged
[external buildsystem] scripts/configure: allow out-of-tree project root #29627
mergify
merged 1 commit into
project-chip:master
from
plan44:PR/scripts-configure-allow-out-of-tree-project-root
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… root The configure script, intended for external build systems such as openwrt, so far only allowed projects contained within the connectedhomeip source tree. This is the case for CHIP examples, but is NOT viable for actual applications, where connectedhomeip is usually a submodule of the main project. This PR changes `scripts/configure` in a backwards compatible way as follows: - absolute paths specified with `--project` are now supported - relative paths specified with `--project` are still relative to CHIP_ROOT, but are also allowed to point outside (using ../../... type path). Tested with actual build of p44mbrd (https://github.com/plan44/p44mbrd) as openwrt package (https://github.com/plan44/plan44-feed/tree/main/p44mbrd)
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 6, 2023 15:22
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic and
tehampson
October 6, 2023 15:22
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 6, 2023 15:22
PR #29627: Size comparison from cff70e1 to 658e819 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 8, 2023
ksperling-apple
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
… root (project-chip#29627) The configure script, intended for external build systems such as openwrt, so far only allowed projects contained within the connectedhomeip source tree. This is the case for CHIP examples, but is NOT viable for actual applications, where connectedhomeip is usually a submodule of the main project. This PR changes `scripts/configure` in a backwards compatible way as follows: - absolute paths specified with `--project` are now supported - relative paths specified with `--project` are still relative to CHIP_ROOT, but are also allowed to point outside (using ../../... type path). Tested with actual build of p44mbrd (https://github.com/plan44/p44mbrd) as openwrt package (https://github.com/plan44/plan44-feed/tree/main/p44mbrd)
plan44
deleted the
PR/scripts-configure-allow-out-of-tree-project-root
branch
October 23, 2023 17:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configure script, intended for external build systems such as openwrt, so far only allowed projects contained within the connectedhomeip source tree.
This is the case for CHIP examples, but not for actual applications, where connectedhomeip is usually a submodule of the main project, and thus not a subdirectory of connectedhomeip.
This PR changes
scripts/configure
in a backwards compatible way as follows:--project
are now supported--project
are still relative to CHIP_ROOT, but are also allowed to point outside (using../../xx
type paths).Tested with actual build of
gn
host package from https://github.com/project-chip/matter-openwrt