-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink] Enable -Wundef by default on Zephyr platform #29613
Conversation
PR #29613: Size comparison from f34b13c to da127c4 Increases (1 build for psoc6)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
PR #29613: Size comparison from f34b13c to fd92f77 Increases (1 build for psoc6)
Decreases (1 build for telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
PR #29613: Size comparison from f34b13c to 224294a Increases (1 build for psoc6)
Full report (40 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
PR #29613: Size comparison from f34b13c to ad08589 Increases (1 build for psoc6)
Decreases (1 build for bl702)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29613: Size comparison from 52225dd to 68fae68 Increases (1 build for psoc6)
Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I prepare a patch to clear nRF config, which you could add to your PR? I don't quite like defining CONFIG_XXX
macros as 0 or the need to add CHIP_DEVICE_CONFIG_ENALE_SED
in the project config but I can help with resolving the original issues.
Gave you access to my fork: https://github.com/Damian-Nordic
|
538083f
to
a3325fc
Compare
@s07641069 OK, I pushed one commit. Let's see if I haven't broken anything :). |
PR #29613: Size comparison from 52225dd to a3325fc Decreases (1 build for telink)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple Looks like PR ready for your next review. |
…9613) * [Telink] Enable -Wundef by default on Zephyr platform * [Telink] Fix builds * [Telink] Fix builds * Restyled by clang-format * [Telink] Fix builds * [Telink] Fix builds * [Telink] add defines * [Telink] add defines * [Telink] add defines * [Telink] clean code * [Telink] clean code * [Telink] clean code * [Telink] fix builds * [Telink] clean code * [Telink] fix builds * [Telink] fix builds * [Telink} Fix builds * [Telink] Fix builds * [Telink] fix builds * Clean nrfconnect config --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Damian Krolik <[email protected]>
Part PR of #29582
Fix issue #29593