-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Fix Yaml 2_1 to 2_4 to enable on CI #29569
Merged
mergify
merged 13 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_enable_yaml_ci
Oct 10, 2023
Merged
[Scenes] Fix Yaml 2_1 to 2_4 to enable on CI #29569
mergify
merged 13 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_enable_yaml_ci
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it should be 3 PRs:
- Fix the code bits that are broken.
- Update the tests to match the test plan (not mixed in with code changes, so it can get reviewed very carefully).
- Enable the tests.
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_yaml_ci
branch
from
October 5, 2023 16:20
f405ba7
to
0ab9646
Compare
lpbeliveau-silabs
changed the title
[Scenes] Activating scenes yaml tests on CI
[Scenes] Fix Yaml 2_1 to 2_4 to enable on CI
Oct 5, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
October 5, 2023 16:25
… handler is implemented
…more spec compliant
Co-authored-by: Boris Zbarsky <[email protected]>
…nd added bitwise check in 1_1
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_yaml_ci
branch
from
October 10, 2023 19:07
ee4b5be
to
1d33721
Compare
rcasallas-silabs
approved these changes
Oct 10, 2023
PR #29569: Size comparison from 6deee69 to 03adda5 Increases (10 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (2 builds for bl602, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29569: Size comparison from 6deee69 to 1d2d6e2 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_yaml_ci
branch
from
October 10, 2023 21:27
1d2d6e2
to
f7fcea5
Compare
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_yaml_ci
branch
from
October 10, 2023 21:38
f7fcea5
to
d72874b
Compare
PR #29569: Size comparison from 7a50966 to d72874b Increases (8 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
6 tasks
This was referenced Oct 19, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Activating scenes yaml tests on CI now that the level control cluster handler is implemented * Restyled by whitespace * Restyled by prettier-yaml * Used G1 instead of raw value where possible, modified TC_S_1_1 to be more spec compliant * Restyled by prettier-yaml * Added comments related to issues and remove un-necessary check * Update src/app/tests/suites/certification/Test_TC_S_1_1.yaml Co-authored-by: Boris Zbarsky <[email protected]> * Added access control in yaml 2_3, fixed group key format and values and added bitwise check in 1_1 * Restyled by whitespace * Restyled by prettier-yaml * Modified TC_S_2_2 to pass the Store Scene test now that level Control is enabled * Restyled by prettier-yaml * Fixed .matter for all clusters app --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the yaml 2_1 to 2_4 compliant with test plan so they can be automated on CI.