-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly Clean out the generated jar and so files from android build #29516
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/clean_android_build
Sep 30, 2023
Merged
Correctly Clean out the generated jar and so files from android build #29516
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/clean_android_build
Sep 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
September 30, 2023 00:51
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
September 30, 2023 00:51
pullapprove
bot
added
review - pending
examples
github
workflows
and removed
examples
github
workflows
labels
Sep 30, 2023
yunhanw-google
force-pushed
the
feature/clean_android_build
branch
from
September 30, 2023 00:52
00ee9dd
to
545dd86
Compare
PR #29516: Size comparison from 48d4d43 to 545dd86 Increases (1 build for bl702l)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 30, 2023
andy31415
approved these changes
Sep 30, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TV-Server and TV-Casting app's jar and so are not located in examples/android/CHIPTool, previously CI cleans the wrong place and result sin 2gb + space waste in full-build, 1gb+ space waste in smoke build.
In addition, indeed so files are stored in examples/.../app/libs/jniLibs/xxx, which needs to be removed, but we also need clean out the generated jar file in examples/.../app/libs/