-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timesync: Force call to delegate so we get time source #29440
Merged
mergify
merged 1 commit into
project-chip:master
from
cecille:timesync_set_initial_time_source_from_delegate
Sep 25, 2023
Merged
Timesync: Force call to delegate so we get time source #29440
mergify
merged 1 commit into
project-chip:master
from
cecille:timesync_set_initial_time_source_from_delegate
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
September 25, 2023 16:43
pullapprove
bot
requested review from
pidarped,
yufengwangca,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple and
younghak-hwang
September 25, 2023 16:44
PR #29440: Size comparison from 33052cc to 422c385 Increases (1 build for telink)
Decreases (12 builds for cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
aronrosenberg
approved these changes
Sep 25, 2023
jrhees-cae
approved these changes
Sep 25, 2023
jrhees-cae
approved these changes
Sep 25, 2023
fessehaeve
approved these changes
Sep 25, 2023
andy31415
approved these changes
Sep 25, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial time source does not get set correctly currently. Rather than guessing, if we just call the delegate, it will call the appropriate callback to set the granularity and time source correctly.