-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chef] Add Air Quality Sensor device type #29436
Merged
mergify
merged 8 commits into
project-chip:master
from
erwinpan1:add_air_quality_sensor
Sep 27, 2023
Merged
[Chef] Add Air Quality Sensor device type #29436
mergify
merged 8 commits into
project-chip:master
from
erwinpan1:add_air_quality_sensor
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinpan1
force-pushed
the
add_air_quality_sensor
branch
from
September 25, 2023 11:44
5996875
to
90be9ab
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
September 25, 2023 11:44
PR #29436: Size comparison from 33052cc to 90be9ab Increases (1 build for telink)
Decreases (1 build for telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 25, 2023
erwinpan1
force-pushed
the
add_air_quality_sensor
branch
from
September 26, 2023 16:24
90be9ab
to
93a1248
Compare
PR #29436: Size comparison from 8ace42e to a925812 Increases (1 build for telink)
Decreases (1 build for telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
examples/chef/devices/rootnode_airqualitysensor_e63187f6c9.matter
Outdated
Show resolved
Hide resolved
PR #29436: Size comparison from 8ace42e to f4eeb69 Decreases (8 builds for cyw30739, esp32, linux, nrfconnect, psoc6)
Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
erwinpan1
force-pushed
the
add_air_quality_sensor
branch
from
September 27, 2023 10:50
f4eeb69
to
9c9be99
Compare
PR #29436: Size comparison from f299acb to 9c9be99 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 27, 2023
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Sep 29, 2023
erwinpan1
added a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Sep 29, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* [Chef] Add Air Quality Sensor * Restyled by whitespace * Restyled by clang-format * Restyled by gn * gen rootnode_airqualitysensor_e63187f6c9.matter * regen rootnode_airqualitysensor_e63187f6c9.matter * Remove group cluster * Assume the AirQuality device endpoint is 1 in Chef --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Chef Air Quality Sensor device type