-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update darwin framework tool project to mimic gn compile flags for KVS #29320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krypton36
commented
Sep 18, 2023
•
edited
Loading
edited
- Update compile flags to mirror GN build of DFT.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
September 18, 2023 15:22
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
September 18, 2023 15:22
PR #29320: Size comparison from 878282e to 171ec18 Decreases (1 build for bl702l)
Full report (36 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6)
|
krypton36
force-pushed
the
UpdateDFTProject
branch
from
September 19, 2023 15:37
171ec18
to
d555c2f
Compare
PR #29320: Size comparison from b7d43a3 to d555c2f Full report (14 builds for bl602, bl702, bl702l, cc32xx, linux, mbed, nrfconnect)
|
krypton36
force-pushed
the
UpdateDFTProject
branch
from
September 19, 2023 16:20
d555c2f
to
f206473
Compare
krypton36
changed the title
Update darwin framework tool project with missing files
Update darwin framework tool project to mimic gn compile flags for KVS
Sep 19, 2023
PR #29320: Size comparison from b7d43a3 to f206473 Increases (1 build for telink)
Full report (43 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, telink)
|
Fast-tracking platform-specific change with platform owner review. |
krypton36
force-pushed
the
UpdateDFTProject
branch
from
September 20, 2023 18:18
f206473
to
690edd5
Compare
PR #29320: Size comparison from 0f620c0 to 690edd5 Full report (25 builds for bl602, bl702, bl702l, cc32xx, linux, mbed, nrfconnect, qpg)
|
andy31415
approved these changes
Sep 20, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.