-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make constexpr constants in headers inline constexpr #29279
Merged
mergify
merged 2 commits into
project-chip:master
from
ksperling-apple:inline-constexpr
Sep 15, 2023
Merged
Make constexpr constants in headers inline constexpr #29279
mergify
merged 2 commits into
project-chip:master
from
ksperling-apple:inline-constexpr
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the linker deduplicate these constants, instead of emitting one definition per compilation unit. E.g. chip::System::Clock::kZero currently exists >10 times in the chip-tool binary.
github-actions
bot
added
tools
examples
transport
system
setup payload
platform
darwin
esp32
nrf connect
lib
crypto
controller
ble
app
tests
support
core
icd
Intermittently Connected Devices
silabs
labels
Sep 15, 2023
PR #29279: Size comparison from d104699 to b2ce8c7 Increases above 0.2%:
Increases (13 builds for linux)
Decreases (76 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (76 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple and
cecille
September 15, 2023 09:51
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 15, 2023 09:51
bzbarsky-apple
approved these changes
Sep 15, 2023
andy31415
approved these changes
Sep 15, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
ble
controller
core
crypto
darwin
esp32
examples
icd
Intermittently Connected Devices
lib
nrf connect
platform
review - approved
setup payload
silabs
support
system
tests
tools
transport
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the linker deduplicate these constants, instead of emitting one
definition per compilation unit. E.g.
chip::System::Clock::kZero
currentlyexists >10 times in the chip-tool binary.