-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CHIP_SYSTEM_CONFIG_USE_TIMER_POOL bits. #29222
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-timer-pool-config
Sep 14, 2023
Merged
Remove CHIP_SYSTEM_CONFIG_USE_TIMER_POOL bits. #29222
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-timer-pool-config
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a config macro we have anymore, and the code it guards does not compile, since System::Timer has no GetStatistics method.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248 and
hicklin
September 13, 2023 19:01
pullapprove
bot
requested review from
tima-q,
pidarped,
tobiasgraf,
plauric,
vivien-apple,
rcasallas-silabs,
woody-apple,
robszewczyk,
younghak-hwang,
saurabhst,
yufengwangca,
selissia,
yunhanw-google,
sharadb-amazon,
tecimovic and
tehampson
September 13, 2023 19:01
PR #29222: Size comparison from af635a6 to b89676c Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 14, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
This is not a config macro we have anymore, and the code it guards does not compile, since System::Timer has no GetStatistics method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a config macro we have anymore, and the code it guards does not compile, since System::Timer has no GetStatistics method.