Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RebootCount storage on Darwin. #29134

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Implement RebootCount storage on Darwin. #29134

merged 2 commits into from
Sep 11, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #29108

@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

PR #29134: Size comparison from 5ae3c65 to 1dc414b

Decreases (1 build for efr32)
platform target config section 5ae3c65 1dc414b change % change
efr32 lighting-app BRD4187C (read/write) 1079212 1079204 -8 -0.0
.text 889928 889920 -8 -0.0
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5ae3c65 1dc414b change % change
bl602 lighting-app bl602 (read/write) 1365590 1365590 0 0.0
.bss 73446 73446 0 0.0
.data 9600 9600 0 0.0
.text 1058580 1058580 0 0.0
bl602+rpc (read/write) 1412730 1412730 0 0.0
.bss 81486 81486 0 0.0
.data 9952 9952 0 0.0
.text 1090258 1090258 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1168647 1168647 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41301 41301 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 3584 3584 0 0.0
.debug_abbrev 1566210 1566210 0 0.0
.debug_aranges 138040 138040 0 0.0
.debug_frame 507536 507536 0 0.0
.debug_info 41823862 41823862 0 0.0
.debug_line 5451292 5451292 0 0.0
.debug_loc 3521300 3521300 0 0.0
.debug_ranges 380648 380648 0 0.0
.debug_str 3954303 3954303 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107100 107100 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 590840 590840 0 0.0
.symtab 176016 176016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955692 955692 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1265467 1265467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1742639 1742639 0 0.0
.debug_aranges 146632 146632 0 0.0
.debug_frame 536620 536620 0 0.0
.debug_info 46725851 46725851 0 0.0
.debug_line 5858605 5858605 0 0.0
.debug_loc 3726341 3726341 0 0.0
.debug_ranges 406488 406488 0 0.0
.debug_str 4375068 4375068 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121972 121972 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 655001 655001 0 0.0
.symtab 195200 195200 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028142 1028142 0 0.0
bl706-eth (read/write) 1014780 1014780 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 25586 25586 0 0.0
.bss_psram 94415 94415 0 0.0
.comment 48 48 0 0.0
.data 3304 3304 0 0.0
.debug_abbrev 1114820 1114820 0 0.0
.debug_aranges 114256 114256 0 0.0
.debug_frame 424224 424224 0 0.0
.debug_info 23277007 23277007 0 0.0
.debug_line 4407711 4407711 0 0.0
.debug_loc 3019266 3019266 0 0.0
.debug_ranges 317384 317384 0 0.0
.debug_str 3525576 3525576 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 97296 97296 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 455889 455889 0 0.0
.symtab 138032 138032 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
773770 773770 0 0.0
bl706-wifi (read/write) 1086991 1086991 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 9981 9981 0 0.0
.bss_psram 95151 95151 0 0.0
.comment 48 48 0 0.0
.data 3624 3624 0 0.0
.debug_abbrev 1207661 1207661 0 0.0
.debug_aranges 118520 118520 0 0.0
.debug_frame 439676 439676 0 0.0
.debug_info 24442220 24442220 0 0.0
.debug_line 4628997 4628997 0 0.0
.debug_loc 3103352 3103352 0 0.0
.debug_ranges 326280 326280 0 0.0
.debug_str 3586977 3586977 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109572 109572 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 492654 492654 0 0.0
.symtab 150544 150544 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3402 3402 0 0.0
.text 0 0 0 0.0
847520 847520 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153876 1153876 0 0.0
.boot2 292 292 0 0.0
.bss 16004 16004 0 0.0
.bss_psram 77648 77648 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1568578 1568578 0 0.0
.debug_aranges 132560 132560 0 0.0
.debug_frame 487252 487252 0 0.0
.debug_info 41830667 41830667 0 0.0
.debug_line 5367514 5367514 0 0.0
.debug_loc 3457012 3457012 0 0.0
.debug_ranges 385968 385968 0 0.0
.debug_str 3966747 3966747 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100964 100964 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 591034 591034 0 0.0
.symtab 175552 175552 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
944186 944186 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 735115 735115 0 0.0
(read/write) 166664 166664 0 0.0
.bss 89076 89076 0 0.0
.data 3424 3424 0 0.0
.rodata 84535 84535 0 0.0
.text 650192 650192 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756451 756451 0 0.0
(read/write) 177056 177056 0 0.0
.bss 99436 99436 0 0.0
.data 3440 3440 0 0.0
.rodata 80015 80015 0 0.0
.text 676044 676044 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744339 744339 0 0.0
(read/write) 171528 171528 0 0.0
.bss 93908 93908 0 0.0
.data 3440 3440 0 0.0
.rodata 106263 106263 0 0.0
.text 637688 637688 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 694787 694787 0 0.0
(read/write) 165900 165900 0 0.0
.bss 88080 88080 0 0.0
.data 3412 3412 0 0.0
.rodata 80423 80423 0 0.0
.text 613972 613972 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 680371 680371 0 0.0
(read/write) 166032 166032 0 0.0
.bss 88224 88224 0 0.0
.data 3408 3408 0 0.0
.rodata 76263 76263 0 0.0
.text 603716 603716 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 617170 617170 0 0.0
(read/write) 207256 207256 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200696 200696 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 966876 966876 0 0.0
.debug_aranges 106760 106760 0 0.0
.debug_frame 361040 361040 0 0.0
.debug_info 21248732 21248732 0 0.0
.debug_line 2797066 2797066 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1568245 1568245 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 98952 98952 0 0.0
.debug_str 3368510 3368510 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106506 106506 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 499912 499912 0 0.0
.symtab 294240 294240 0 0.0
.text 508540 508540 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 553071 553071 0 0.0
.app_xip_area 444089 444089 0 0.0
.bss 63952 63952 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539527 539527 0 0.0
.app_xip_area 425609 425609 0 0.0
.bss 68856 68856 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574879 574879 0 0.0
.app_xip_area 467097 467097 0 0.0
.bss 62824 62824 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558639 558639 0 0.0
.app_xip_area 447649 447649 0 0.0
.bss 65936 65936 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1005276 1005276 0 0.0
.bss 172132 172132 0 0.0
.data 2668 2668 0 0.0
.text 830456 830456 0 0.0
BRD4187C (read/write) 1079212 1079204 -8 -0.0
.bss 186008 186008 0 0.0
.data 3256 3256 0 0.0
.text 889928 889920 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1103124 1103124 0 0.0
.bss 186956 186956 0 0.0
.data 2684 2684 0 0.0
.text 913464 913464 0 0.0
window-app BRD4187C (read/write) 1128120 1128120 0 0.0
.bss 168768 168768 0 0.0
.data 3132 3132 0 0.0
.text 956200 956200 0 0.0
esp32 all-clusters-app c3devkit (read only) 1173026 1173026 0 0.0
(read/write) 1703788 1703788 0 0.0
.dram0.bss 79056 79056 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 268736 268736 0 0.0
.flash.text 1173026 1173026 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1213955 1213955 0 0.0
(read/write) 553258 553258 0 0.0
.dram0.bss 85672 85672 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 299932 299932 0 0.0
.flash.text 1208571 1208571 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 590060 590060 0 0.0
(read/write) 87920 87920 0 0.0
.bss 71168 71168 0 0.0
.data 2128 2128 0 0.0
.text 589524 589524 0 0.0
light k32w0+release (read only) 589868 589868 0 0.0
(read/write) 87596 87596 0 0.0
.bss 70856 70856 0 0.0
.data 2116 2116 0 0.0
.text 589332 589332 0 0.0
lock k32w0+release (read only) 561220 561220 0 0.0
(read/write) 85372 85372 0 0.0
.bss 68688 68688 0 0.0
.data 2060 2060 0 0.0
.text 560684 560684 0 0.0
linux all-clusters-app debug (read only) 5650073 5650073 0 0.0
(read/write) 420104 420104 0 0.0
.bss 130400 130400 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 278296 278296 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 339284 339284 0 0.0
.text 4929635 4929635 0 0.0
all-clusters-minimal-app debug (read only) 4915545 4915545 0 0.0
(read/write) 232352 232352 0 0.0
.bss 126336 126336 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 95024 95024 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272552 272552 0 0.0
.text 4412243 4412243 0 0.0
bridge-app debug (read only) 2772585 2772585 0 0.0
(read/write) 133136 133136 0 0.0
.bss 51768 51768 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71440 71440 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214504 214504 0 0.0
.text 2380435 2380435 0 0.0
chip-tool debug (read only) 10332705 10332705 0 0.0
(read/write) 441784 441784 0 0.0
.bss 93688 93688 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 335760 335760 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 388785 388785 0 0.0
.text 9348435 9348435 0 0.0
chip-tool-ipv6only arm64 (read only) 10174140 10174140 0 0.0
(read/write) 504232 504232 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 373128 373128 0 0.0
.dynamic 512 512 0 0.0
.got 18192 18192 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316168 316168 0 0.0
.text 9093992 9093992 0 0.0
lighting-app debug+rpc+ui (read only) 5247449 5247449 0 0.0
(read/write) 222504 222504 0 0.0
.bss 118032 118032 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92376 92376 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336820 336820 0 0.0
.text 4668195 4668195 0 0.0
lock-app debug (read only) 4478993 4478993 0 0.0
(read/write) 203096 203096 0 0.0
.bss 113456 113456 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 79080 79080 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248456 248456 0 0.0
.text 4021043 4021043 0 0.0
ota-provider-app debug (read only) 4130433 4130433 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113600 113600 0 0.0
.data 4032 4032 0 0.0
.data.rel.ro 68480 68480 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201128 201128 0 0.0
.text 3738867 3738867 0 0.0
ota-requestor-app debug (read only) 4223897 4223897 0 0.0
(read/write) 196344 196344 0 0.0
.bss 114656 114656 0 0.0
.data 4272 4272 0 0.0
.data.rel.ro 71480 71480 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204456 204456 0 0.0
.text 3824675 3824675 0 0.0
shell debug (read only) 3051025 3051025 0 0.0
(read/write) 153520 153520 0 0.0
.bss 60808 60808 0 0.0
.data 784 784 0 0.0
.data.rel.ro 85992 85992 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 214546 214546 0 0.0
.text 2661986 2661986 0 0.0
thermostat-no-ble arm64 (read only) 4358076 4358076 0 0.0
(read/write) 241896 241896 0 0.0
.bss 122200 122200 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 100512 100512 0 0.0
.dynamic 512 512 0 0.0
.got 11824 11824 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161236 161236 0 0.0
.text 3862776 3862776 0 0.0
tv-app debug (read only) 5321281 5321281 0 0.0
(read/write) 350824 350824 0 0.0
.bss 242016 242016 0 0.0
.data 5136 5136 0 0.0
.data.rel.ro 96256 96256 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272920 272920 0 0.0
.text 4804307 4804307 0 0.0
tv-casting-app debug (read only) 8279993 8279993 0 0.0
(read/write) 211288 211288 0 0.0
.bss 54720 54720 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147224 147224 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 338396 338396 0 0.0
.text 7541091 7541091 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523272 2523272 0 0.0
.bss 219416 219416 0 0.0
.data 5128 5128 0 0.0
.text 1485956 1485956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1241144 1241144 0 0.0
bss 155438 155438 0 0.0
rodata 143084 143084 0 0.0
text 863572 863572 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1359524 1359524 0 0.0
bss 140904 140904 0 0.0
rodata 136988 136988 0 0.0
text 790928 790928 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161192 1161192 0 0.0
bss 154836 154836 0 0.0
rodata 113796 113796 0 0.0
text 813608 813608 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837184 837184 0 0.0
(read/write) 1794036 1794036 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193604 193604 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1425518 1425518 0 0.0
.debug_aranges 145320 145320 0 0.0
.debug_frame 483360 483360 0 0.0
.debug_info 33667919 33667919 0 0.0
.debug_line 4246420 4246420 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2305623 2305623 0 0.0
.debug_rnglists 144535 144535 0 0.0
.debug_str 4537083 4537083 0 0.0
.heap 837184 837184 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 852092 852092 0 0.0
.symtab 515712 515712 0 0.0
.text 0 0 0 0.0
1589492 1589492 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839944 839944 0 0.0
(read/write) 1678772 1678772 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190932 190932 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1290839 1290839 0 0.0
.debug_aranges 135040 135040 0 0.0
.debug_frame 454444 454444 0 0.0
.debug_info 29296188 29296188 0 0.0
.debug_line 3948234 3948234 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2121584 2121584 0 0.0
.debug_rnglists 134005 134005 0 0.0
.debug_str 3922760 3922760 0 0.0
.heap 839944 839944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 719967 719967 0 0.0
.symtab 467744 467744 0 0.0
.text 1476988 1476988 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846280 846280 0 0.0
(read/write) 1607084 1607084 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184708 184708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1130664 1130664 0 0.0
.debug_aranges 125136 125136 0 0.0
.debug_frame 417488 417488 0 0.0
.debug_info 2434956 2434956 0 0.0
.debug_line 3512671 3512671 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1958367 1958367 0 0.0
.debug_rnglists 123702 123702 0 0.0
.debug_str 3730003 3730003 0 0.0
.heap 846280 846280 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 637532 637532 0 0.0
.symtab 431280 431280 0 0.0
.text 1411636 1411636 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818880 818880 0 0.0
(read/write) 1640356 1640356 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212092 212092 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1121628 1121628 0 0.0
.debug_aranges 123944 123944 0 0.0
.debug_frame 413140 413140 0 0.0
.debug_info 24161035 24161035 0 0.0
.debug_line 3465688 3465688 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1936873 1936873 0 0.0
.debug_rnglists 121798 121798 0 0.0
.debug_str 3693392 3693392 0 0.0
.heap 818880 818880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 611607 611607 0 0.0
.symtab 423328 423328 0 0.0
.text 1417508 1417508 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177940 1177940 0 0.0
.bss 101024 101024 0 0.0
.data 744 744 0 0.0
.text 624784 624784 0 0.0
lock-app qpg6105+debug (read/write) 1134212 1134212 0 0.0
.bss 95728 95728 0 0.0
.data 748 748 0 0.0
.text 581052 581052 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1100304 1100304 0 0.0
bss 112252 112252 0 0.0
text 753190 753190 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1038036 1038036 0 0.0
bss 110032 110032 0 0.0
text 704416 704416 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948896 948896 0 0.0
bss 113748 113748 0 0.0
text 648306 648306 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 931948 931948 0 0.0
bss 103372 103372 0 0.0
text 620804 620804 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 925856 925856 0 0.0
bss 103616 103616 0 0.0
text 632376 632376 0 0.0
lighting-app-rpc-shell-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 999472 999472 0 0.0
bss 115848 115848 0 0.0
text 695486 695486 0 0.0
tlsr9528a (read only) 4 4 0 0.0
(read/write) 1051820 1051820 0 0.0
bss 116452 116452 0 0.0
text 725480 725480 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 990028 990028 0 0.0
bss 104092 104092 0 0.0
text 651950 651950 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 903584 903584 0 0.0
bss 104108 104108 0 0.0
text 613730 613730 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 937388 937388 0 0.0
bss 103504 103504 0 0.0
text 626450 626450 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 872084 872084 0 0.0
bss 102708 102708 0 0.0
text 586756 586756 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 748852 748852 0 0.0
bss 101572 101572 0 0.0
text 479376 479376 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 935456 935456 0 0.0
bss 103484 103484 0 0.0
text 625168 625168 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 920684 920684 0 0.0
bss 103212 103212 0 0.0
text 612498 612498 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 893516 893516 0 0.0
bss 103000 103000 0 0.0
text 602466 602466 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 889140 889140 0 0.0
bss 103324 103324 0 0.0
text 597796 597796 0 0.0

@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

PR #29134: Size comparison from 5ae3c65 to c6523f4

Decreases (1 build for efr32)
platform target config section 5ae3c65 c6523f4 change % change
efr32 lighting-app BRD4187C (read/write) 1079212 1079204 -8 -0.0
.text 889928 889920 -8 -0.0
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5ae3c65 c6523f4 change % change
bl602 lighting-app bl602 (read/write) 1365590 1365590 0 0.0
.bss 73446 73446 0 0.0
.data 9600 9600 0 0.0
.text 1058580 1058580 0 0.0
bl602+rpc (read/write) 1412730 1412730 0 0.0
.bss 81486 81486 0 0.0
.data 9952 9952 0 0.0
.text 1090258 1090258 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1168647 1168647 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41301 41301 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 3584 3584 0 0.0
.debug_abbrev 1566210 1566210 0 0.0
.debug_aranges 138040 138040 0 0.0
.debug_frame 507536 507536 0 0.0
.debug_info 41823862 41823862 0 0.0
.debug_line 5451292 5451292 0 0.0
.debug_loc 3521300 3521300 0 0.0
.debug_ranges 380648 380648 0 0.0
.debug_str 3954303 3954303 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107100 107100 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 590840 590840 0 0.0
.symtab 176016 176016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955692 955692 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1265467 1265467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1742639 1742639 0 0.0
.debug_aranges 146632 146632 0 0.0
.debug_frame 536620 536620 0 0.0
.debug_info 46725851 46725851 0 0.0
.debug_line 5858605 5858605 0 0.0
.debug_loc 3726341 3726341 0 0.0
.debug_ranges 406488 406488 0 0.0
.debug_str 4375068 4375068 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121972 121972 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 655001 655001 0 0.0
.symtab 195200 195200 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028142 1028142 0 0.0
bl706-eth (read/write) 1014780 1014780 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 25586 25586 0 0.0
.bss_psram 94415 94415 0 0.0
.comment 48 48 0 0.0
.data 3304 3304 0 0.0
.debug_abbrev 1114820 1114820 0 0.0
.debug_aranges 114256 114256 0 0.0
.debug_frame 424224 424224 0 0.0
.debug_info 23277007 23277007 0 0.0
.debug_line 4407711 4407711 0 0.0
.debug_loc 3019266 3019266 0 0.0
.debug_ranges 317384 317384 0 0.0
.debug_str 3525576 3525576 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 97296 97296 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 455889 455889 0 0.0
.symtab 138032 138032 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
773770 773770 0 0.0
bl706-wifi (read/write) 1086991 1086991 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 9981 9981 0 0.0
.bss_psram 95151 95151 0 0.0
.comment 48 48 0 0.0
.data 3624 3624 0 0.0
.debug_abbrev 1207661 1207661 0 0.0
.debug_aranges 118520 118520 0 0.0
.debug_frame 439676 439676 0 0.0
.debug_info 24442220 24442220 0 0.0
.debug_line 4628997 4628997 0 0.0
.debug_loc 3103352 3103352 0 0.0
.debug_ranges 326280 326280 0 0.0
.debug_str 3586977 3586977 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109572 109572 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 492654 492654 0 0.0
.symtab 150544 150544 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3402 3402 0 0.0
.text 0 0 0 0.0
847520 847520 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153876 1153876 0 0.0
.boot2 292 292 0 0.0
.bss 16004 16004 0 0.0
.bss_psram 77648 77648 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1568578 1568578 0 0.0
.debug_aranges 132560 132560 0 0.0
.debug_frame 487252 487252 0 0.0
.debug_info 41830667 41830667 0 0.0
.debug_line 5367514 5367514 0 0.0
.debug_loc 3457012 3457012 0 0.0
.debug_ranges 385968 385968 0 0.0
.debug_str 3966747 3966747 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100964 100964 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 591034 591034 0 0.0
.symtab 175552 175552 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
944186 944186 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 735115 735115 0 0.0
(read/write) 166664 166664 0 0.0
.bss 89076 89076 0 0.0
.data 3424 3424 0 0.0
.rodata 84535 84535 0 0.0
.text 650192 650192 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756451 756451 0 0.0
(read/write) 177056 177056 0 0.0
.bss 99436 99436 0 0.0
.data 3440 3440 0 0.0
.rodata 80015 80015 0 0.0
.text 676044 676044 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744339 744339 0 0.0
(read/write) 171528 171528 0 0.0
.bss 93908 93908 0 0.0
.data 3440 3440 0 0.0
.rodata 106263 106263 0 0.0
.text 637688 637688 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 694787 694787 0 0.0
(read/write) 165900 165900 0 0.0
.bss 88080 88080 0 0.0
.data 3412 3412 0 0.0
.rodata 80423 80423 0 0.0
.text 613972 613972 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 680371 680371 0 0.0
(read/write) 166032 166032 0 0.0
.bss 88224 88224 0 0.0
.data 3408 3408 0 0.0
.rodata 76263 76263 0 0.0
.text 603716 603716 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 617170 617170 0 0.0
(read/write) 207256 207256 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200696 200696 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 966876 966876 0 0.0
.debug_aranges 106760 106760 0 0.0
.debug_frame 361040 361040 0 0.0
.debug_info 21248732 21248732 0 0.0
.debug_line 2797066 2797066 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1568245 1568245 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 98952 98952 0 0.0
.debug_str 3368510 3368510 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106506 106506 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 499912 499912 0 0.0
.symtab 294240 294240 0 0.0
.text 508540 508540 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 553071 553071 0 0.0
.app_xip_area 444089 444089 0 0.0
.bss 63952 63952 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539527 539527 0 0.0
.app_xip_area 425609 425609 0 0.0
.bss 68856 68856 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574879 574879 0 0.0
.app_xip_area 467097 467097 0 0.0
.bss 62824 62824 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 558639 558639 0 0.0
.app_xip_area 447649 447649 0 0.0
.bss 65936 65936 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1005276 1005276 0 0.0
.bss 172132 172132 0 0.0
.data 2668 2668 0 0.0
.text 830456 830456 0 0.0
BRD4187C (read/write) 1079212 1079204 -8 -0.0
.bss 186008 186008 0 0.0
.data 3256 3256 0 0.0
.text 889928 889920 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1103124 1103124 0 0.0
.bss 186956 186956 0 0.0
.data 2684 2684 0 0.0
.text 913464 913464 0 0.0
window-app BRD4187C (read/write) 1128120 1128120 0 0.0
.bss 168768 168768 0 0.0
.data 3132 3132 0 0.0
.text 956200 956200 0 0.0
esp32 all-clusters-app c3devkit (read only) 1173026 1173026 0 0.0
(read/write) 1703788 1703788 0 0.0
.dram0.bss 79056 79056 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 268736 268736 0 0.0
.flash.text 1173026 1173026 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1213955 1213955 0 0.0
(read/write) 553258 553258 0 0.0
.dram0.bss 85672 85672 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 299932 299932 0 0.0
.flash.text 1208571 1208571 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 590060 590060 0 0.0
(read/write) 87920 87920 0 0.0
.bss 71168 71168 0 0.0
.data 2128 2128 0 0.0
.text 589524 589524 0 0.0
light k32w0+release (read only) 589868 589868 0 0.0
(read/write) 87596 87596 0 0.0
.bss 70856 70856 0 0.0
.data 2116 2116 0 0.0
.text 589332 589332 0 0.0
lock k32w0+release (read only) 561220 561220 0 0.0
(read/write) 85372 85372 0 0.0
.bss 68688 68688 0 0.0
.data 2060 2060 0 0.0
.text 560684 560684 0 0.0
linux all-clusters-app debug (read only) 5650073 5650073 0 0.0
(read/write) 420104 420104 0 0.0
.bss 130400 130400 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 278296 278296 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 339284 339284 0 0.0
.text 4929635 4929635 0 0.0
all-clusters-minimal-app debug (read only) 4915545 4915545 0 0.0
(read/write) 232352 232352 0 0.0
.bss 126336 126336 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 95024 95024 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272552 272552 0 0.0
.text 4412243 4412243 0 0.0
bridge-app debug (read only) 2772585 2772585 0 0.0
(read/write) 133136 133136 0 0.0
.bss 51768 51768 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71440 71440 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214504 214504 0 0.0
.text 2380435 2380435 0 0.0
chip-tool debug (read only) 10332705 10332705 0 0.0
(read/write) 441784 441784 0 0.0
.bss 93688 93688 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 335760 335760 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 388785 388785 0 0.0
.text 9348435 9348435 0 0.0
chip-tool-ipv6only arm64 (read only) 10174140 10174140 0 0.0
(read/write) 504232 504232 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 373128 373128 0 0.0
.dynamic 512 512 0 0.0
.got 18192 18192 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316168 316168 0 0.0
.text 9093992 9093992 0 0.0
lighting-app debug+rpc+ui (read only) 5247449 5247449 0 0.0
(read/write) 222504 222504 0 0.0
.bss 118032 118032 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92376 92376 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336820 336820 0 0.0
.text 4668195 4668195 0 0.0
lock-app debug (read only) 4478993 4478993 0 0.0
(read/write) 203096 203096 0 0.0
.bss 113456 113456 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 79080 79080 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248456 248456 0 0.0
.text 4021043 4021043 0 0.0
ota-provider-app debug (read only) 4130433 4130433 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113600 113600 0 0.0
.data 4032 4032 0 0.0
.data.rel.ro 68480 68480 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201128 201128 0 0.0
.text 3738867 3738867 0 0.0
ota-requestor-app debug (read only) 4223897 4223897 0 0.0
(read/write) 196344 196344 0 0.0
.bss 114656 114656 0 0.0
.data 4272 4272 0 0.0
.data.rel.ro 71480 71480 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204456 204456 0 0.0
.text 3824675 3824675 0 0.0
shell debug (read only) 3051025 3051025 0 0.0
(read/write) 153520 153520 0 0.0
.bss 60808 60808 0 0.0
.data 784 784 0 0.0
.data.rel.ro 85992 85992 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 214546 214546 0 0.0
.text 2661986 2661986 0 0.0
thermostat-no-ble arm64 (read only) 4358076 4358076 0 0.0
(read/write) 241896 241896 0 0.0
.bss 122200 122200 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 100512 100512 0 0.0
.dynamic 512 512 0 0.0
.got 11824 11824 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161236 161236 0 0.0
.text 3862776 3862776 0 0.0
tv-app debug (read only) 5321281 5321281 0 0.0
(read/write) 350824 350824 0 0.0
.bss 242016 242016 0 0.0
.data 5136 5136 0 0.0
.data.rel.ro 96256 96256 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272920 272920 0 0.0
.text 4804307 4804307 0 0.0
tv-casting-app debug (read only) 8279993 8279993 0 0.0
(read/write) 211288 211288 0 0.0
.bss 54720 54720 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147224 147224 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 338396 338396 0 0.0
.text 7541091 7541091 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523272 2523272 0 0.0
.bss 219416 219416 0 0.0
.data 5128 5128 0 0.0
.text 1485956 1485956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1241144 1241144 0 0.0
bss 155438 155438 0 0.0
rodata 143084 143084 0 0.0
text 863572 863572 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1359524 1359524 0 0.0
bss 140904 140904 0 0.0
rodata 136988 136988 0 0.0
text 790928 790928 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161192 1161192 0 0.0
bss 154836 154836 0 0.0
rodata 113796 113796 0 0.0
text 813608 813608 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837184 837184 0 0.0
(read/write) 1794036 1794036 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193604 193604 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1425518 1425518 0 0.0
.debug_aranges 145320 145320 0 0.0
.debug_frame 483360 483360 0 0.0
.debug_info 33667919 33667919 0 0.0
.debug_line 4246420 4246420 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2305623 2305623 0 0.0
.debug_rnglists 144535 144535 0 0.0
.debug_str 4537083 4537083 0 0.0
.heap 837184 837184 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 852092 852092 0 0.0
.symtab 515712 515712 0 0.0
.text 1589492 1589492 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839944 839944 0 0.0
(read/write) 1678772 1678772 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190932 190932 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1290839 1290839 0 0.0
.debug_aranges 135040 135040 0 0.0
.debug_frame 454444 454444 0 0.0
.debug_info 29296188 29296188 0 0.0
.debug_line 3948234 3948234 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2121584 2121584 0 0.0
.debug_rnglists 134005 134005 0 0.0
.debug_str 3922760 3922760 0 0.0
.heap 839944 839944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 719967 719967 0 0.0
.symtab 467744 467744 0 0.0
.text 1476988 1476988 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846280 846280 0 0.0
(read/write) 1607084 1607084 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184708 184708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1130664 1130664 0 0.0
.debug_aranges 125136 125136 0 0.0
.debug_frame 417488 417488 0 0.0
.debug_info 2434956 2434956 0 0.0
.debug_line 3512671 3512671 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1958367 1958367 0 0.0
.debug_rnglists 123702 123702 0 0.0
.debug_str 3730003 3730003 0 0.0
.heap 846280 846280 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 637532 637532 0 0.0
.symtab 431280 431280 0 0.0
.text 1411636 1411636 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818880 818880 0 0.0
(read/write) 1640356 1640356 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212092 212092 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1121628 1121628 0 0.0
.debug_aranges 123944 123944 0 0.0
.debug_frame 413140 413140 0 0.0
.debug_info 24161035 24161035 0 0.0
.debug_line 3465688 3465688 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1936873 1936873 0 0.0
.debug_rnglists 121798 121798 0 0.0
.debug_str 3693392 3693392 0 0.0
.heap 818880 818880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 611607 611607 0 0.0
.symtab 423328 423328 0 0.0
.text 1417508 1417508 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177940 1177940 0 0.0
.bss 101024 101024 0 0.0
.data 744 744 0 0.0
.text 624784 624784 0 0.0
lock-app qpg6105+debug (read/write) 1134212 1134212 0 0.0
.bss 95728 95728 0 0.0
.data 748 748 0 0.0
.text 581052 581052 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1100304 1100304 0 0.0
bss 112252 112252 0 0.0
text 753190 753190 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1038036 1038036 0 0.0
bss 110032 110032 0 0.0
text 704416 704416 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948896 948896 0 0.0
bss 113748 113748 0 0.0
text 648306 648306 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 931948 931948 0 0.0
bss 103372 103372 0 0.0
text 620804 620804 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 925856 925856 0 0.0
bss 103616 103616 0 0.0
text 632376 632376 0 0.0
lighting-app-rpc-shell-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 999472 999472 0 0.0
bss 115848 115848 0 0.0
text 695486 695486 0 0.0
tlsr9528a (read only) 4 4 0 0.0
(read/write) 1051820 1051820 0 0.0
bss 116452 116452 0 0.0
text 725480 725480 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 990028 990028 0 0.0
bss 104092 104092 0 0.0
text 651950 651950 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 903584 903584 0 0.0
bss 104108 104108 0 0.0
text 613730 613730 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 937388 937388 0 0.0
bss 103504 103504 0 0.0
text 626450 626450 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 872084 872084 0 0.0
bss 102708 102708 0 0.0
text 586756 586756 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 748852 748852 0 0.0
bss 101572 101572 0 0.0
text 479376 479376 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 935456 935456 0 0.0
bss 103484 103484 0 0.0
text 625168 625168 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 920684 920684 0 0.0
bss 103212 103212 0 0.0
text 612498 612498 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 893516 893516 0 0.0
bss 103000 103000 0 0.0
text 602466 602466 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 889140 889140 0 0.0
bss 103324 103324 0 0.0
text 597796 597796 0 0.0

@mergify mergify bot merged commit b274b9e into project-chip:master Sep 11, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-reboot-count branch September 11, 2023 19:09
nivi-apple
nivi-apple reviewed Sep 11, 2023
View reviewed changes
src/platform/Darwin/DiagnosticDataProviderImpl.cpp
@@ -89,6 +89,21 @@ CHIP_ERROR DiagnosticDataProviderImpl::ResetWatermarks()
return CHIP_NO_ERROR;
}

CHIP_ERROR DiagnosticDataProviderImpl::GetRebootCount(uint16_t & rebootCount)
{
uint32_t count = 0;
Copy link
Contributor

@nivi-apple nivi-apple Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this uint32_t? and then cast to uint16_t on line 101? could it be uint16_t count?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this uint32_t? and then cast to uint16_t on line 101?

Because the configuration manager API is:

virtual CHIP_ERROR GetRebootCount(uint32_t & rebootCount)                          = 0;

Now why is that one 32-bit while the actual value in the spec is 16-bit? I don't really know, and it's very out of scope for this PR to change.

abpoth pushed a commit to abpoth/connectedhomeip that referenced this pull request Sep 12, 2023
@bzbarsky-apple @abpoth
Implement RebootCount storage on Darwin. (project-chip#29134)
5f81692 
* Implement RebootCount storage on Darwin.

Fixes project-chip#29108

* Address review comment.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@bzbarsky-apple @HunsupJung
Implement RebootCount storage on Darwin. (project-chip#29134)
9a4b925 
* Implement RebootCount storage on Darwin.

Fixes project-chip#29108

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivi-apple nivi-apple nivi-apple left review comments

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin fast track platform review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Darwin] Need implementation of DiagnosticDataProviderImpl::GetRebootCount
4 participants
@bzbarsky-apple @yunhanw-google @nivi-apple @andy31415