-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MatterYamlTests] null values that are saved are not substituted when… #29107
[MatterYamlTests] null values that are saved are not substituted when… #29107
Conversation
PR #29107: Size comparison from 5867ac5 to 6918760 Full report (2 builds for cc32xx, mbed)
|
6918760
to
5736e8c
Compare
PR #29107: Size comparison from 5867ac5 to 5736e8c Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
5736e8c
to
31d6b21
Compare
PR #29107: Size comparison from ce66c4d to 31d6b21 Increases (1 build for bl702)
Decreases (2 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29107: Size comparison from ce66c4d to 61c8c8e Increases (1 build for bl702)
Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
61c8c8e
to
b1bf1b8
Compare
PR #29107: Size comparison from ce66c4d to b1bf1b8 Increases (1 build for bl702)
Decreases (2 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
b1bf1b8
to
eed22e6
Compare
PR #29107: Size comparison from e29cd6a to eed22e6 Increases (2 builds for bl702, telink)
Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
eed22e6
to
a53e014
Compare
PR #29107: Size comparison from 771d55c to a53e014 Full report (9 builds for cc32xx, linux, mbed, nrfconnect, qpg)
|
…tituted when the key used to saved them is used
…t the same as the attribute since this is a common mistake and it confuses the test suite that does not know if the attribute name should be replaced or not
a53e014
to
9c3d189
Compare
PR #29107: Size comparison from 771d55c to 9c3d189 Decreases (1 build for efr32)
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
…read attribute with the exact same name than the attribute itself
9c3d189
to
e99bc04
Compare
PR #29107: Size comparison from d8480f1 to e99bc04 Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
project-chip#29107) * [MatterYamlTests] null values that are saved with saveAs are not substituted when the key used to saved them is used * Update darwin-framework-tool tests codegen * Add a new check in yaml_loader.py to ensure than the saveAs key is not the same as the attribute since this is a common mistake and it confuses the test suite that does not know if the attribute name should be replaced or not * Update various YAML files such that they do not save the result of a read attribute with the exact same name than the attribute itself
… the key used to saved them is used
fix #29086
It looks like a regression that I have introduced while working on the pics checker. I have added a test in
TestSaveAs.yaml