-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] feature/DIC feature support for thermostat app and window app #29084
Merged
mergify
merged 7 commits into
project-chip:master
from
Thirsrin:feature/DIC_Support_for_thermostat_window_app
Sep 12, 2023
Merged
[Silabs] feature/DIC feature support for thermostat app and window app #29084
mergify
merged 7 commits into
project-chip:master
from
Thirsrin:feature/DIC_Support_for_thermostat_window_app
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
September 6, 2023 10:37
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca and
yunhanw-google
September 6, 2023 10:37
PR #29084: Size comparison from 6b708ab to a9bcd58 Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29084: Size comparison from 6b708ab to 6f68f93 Full report (1 build for cc32xx)
|
Thirsrin
force-pushed
the
feature/DIC_Support_for_thermostat_window_app
branch
from
September 6, 2023 17:26
6f68f93
to
31aa4de
Compare
PR #29084: Size comparison from 741210d to 31aa4de Increases (3 builds for bl702, telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Sep 6, 2023
PR #29084: Size comparison from 741210d to 469c04d Increases (4 builds for bl702, efr32, telink)
Decreases (7 builds for cc32xx, efr32, psoc6)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Thirsrin
force-pushed
the
feature/DIC_Support_for_thermostat_window_app
branch
from
September 7, 2023 14:53
469c04d
to
f44d99d
Compare
PR #29084: Size comparison from 5867ac5 to f44d99d Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Sep 7, 2023
Thirsrin
force-pushed
the
feature/DIC_Support_for_thermostat_window_app
branch
from
September 8, 2023 05:08
16fc46d
to
43536d4
Compare
PR #29084: Size comparison from ce66c4d to 43536d4 Increases (1 build for bl702)
Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 12, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
project-chip#29084) * feature/DIC feature support for thermostat app and window app * Restyled by whitespace * Restyled by clang-format * addressed review comments * Restyled by clang-format * addressed review comments * addressed review comments --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added :
Tested: