-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Modify AndroidControllerExceptions errorCode type #29046
[Android] Modify AndroidControllerExceptions errorCode type #29046
Conversation
PR #29046: Size comparison from 54038c0 to 638d894 Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the crash log, it seems it is using old code, which don't have JL,
java.lang.NoSuchMethodError: no non-static method "Lchip/devicecontroller/ChipDeviceControllerException;.(ILjava/lang/String;)V"
We are using Long to respresent uint32_t when converting uint32_t from jni to java
Fix #29039
Fixed the errorCode variable types of ChipDeviceControllerException class and ThrowError jni type being different.
The return type of the AsInteger() function of CHIP_ERROR is uint32_t.
For this reason, I think it is okay to change the errorCode variable type of ChipDeviceControllerException to int.
uint32_t range : 0 ~ 4294967295
java int range : -2,147,483,648 ~ 2,147,483,647