-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Added the color-control cluster handler for scenes EFS #29026
Merged
mergify
merged 5 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes-color-control-handler
Sep 12, 2023
Merged
[Scenes] Added the color-control cluster handler for scenes EFS #29026
mergify
merged 5 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes-color-control-handler
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
LuDuda and
mhazley
September 1, 2023 21:13
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
September 1, 2023 21:13
lpbeliveau-silabs
force-pushed
the
feature/scenes-color-control-handler
branch
from
September 1, 2023 21:23
e5280f5
to
a82b7ff
Compare
PR #29026: Size comparison from 6cb9720 to a82b7ff Increases above 0.2%:
Increases (29 builds for bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, bl702l, psoc6)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Sep 1, 2023
PR #29026: Size comparison from 6cb9720 to 9524929 Increases above 0.2%:
Increases (41 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (37 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, psoc6, qpg, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…anges in the move to commands introduced by the helpers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied suggestions.
bzbarsky-apple
approved these changes
Sep 12, 2023
jmartinez-silabs
approved these changes
Sep 12, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ect-chip#29026) * Added the color-control cluster handler for scenes EFS * Reworked the logic when applying scene and added checks on boundaries * Modified SerializeSave to explicitely use default value on Attributes::Get failure * Removed enum for attribute index as no longer needed, reverted the changes in the move to commands introduced by the helpers * Fix commenting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables color control through scenes actions by adding a default handler to the color control server.