-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating Darwin controllers via alloc/initWithParameters. #29025
Merged
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:controller-init-cleanup
Sep 6, 2023
Merged
Allow creating Darwin controllers via alloc/initWithParameters. #29025
mergify
merged 2 commits into
project-chip:master
from
bzbarsky-apple:controller-init-cleanup
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
controller-init-cleanup
branch
from
September 1, 2023 21:21
1516680
to
f17493f
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
September 1, 2023 21:21
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 1, 2023 21:21
PR #29025: Size comparison from 6cb9720 to f17493f Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29025: Size comparison from 6cb9720 to c77c209 Increases above 0.2%:
Increases (34 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (41 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
controller-init-cleanup
branch
from
September 5, 2023 18:29
c77c209
to
6dc24db
Compare
PR #29025: Size comparison from 14cbb32 to 6dc24db Full report (1 build for cc32xx)
|
bzbarsky-apple
force-pushed
the
controller-init-cleanup
branch
from
September 5, 2023 18:46
6dc24db
to
20c307a
Compare
PR #29025: Size comparison from 14cbb32 to 20c307a Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
approved these changes
Sep 5, 2023
Fast-tracking platform-specific fix with platform owner review. |
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
…ect-chip#29025) * Allow creating Darwin controllers via alloc/initWithParameters. * Address review comment.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ect-chip#29025) * Allow creating Darwin controllers via alloc/initWithParameters. * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.