-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SED related code from SDK #29023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
September 1, 2023 20:20
pullapprove
bot
requested review from
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 1, 2023 20:20
PR #29023: Size comparison from 8bd7e08 to 52235d3 Increases (5 builds for bl702, bl702l)
Decreases (30 builds for bl702, bl702l, cc32xx, cyw30739, efr32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
approved these changes
Sep 1, 2023
bzbarsky-apple
approved these changes
Sep 1, 2023
pidarped
approved these changes
Sep 1, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
s07641069
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 13, 2023
…ed by ICD (project-chip#29023)" This reverts commit 29fd8dc.
s07641069
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 13, 2023
…ed by ICD (project-chip#29023)" This reverts commit 29fd8dc.
s07641069
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 13, 2023
…ed by ICD (project-chip#29023)" This reverts commit 29fd8dc.
s07641069
added a commit
to s07641069/connectedhomeip
that referenced
this pull request
Sep 14, 2023
…ed by ICD (project-chip#29023)" This reverts commit 29fd8dc.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28237
SED is deprecated by the ICD behaviour.
Some definitions of
CHIP_DEVICE_CONFIG_ENABLE_SED
and use if its ifdef still exist on some platform code.I'll make an announcement on the
tsg-tt-platform-software-dev
channel before changing their configurations.