Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some review comments on Darwin controller data store. #29003

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Address some review comments on Darwin controller data store. #29003

merged 1 commit into from
Sep 1, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

  1. More efficient copying of arrays.
  2. Make it clear what classes need to go in our storage class list.

@bzbarsky-apple
Address some review comments on Darwin controller data store.
8bfc4b2 
1) More efficient copying of arrays.
2) Make it clear what classes need to go in our storage class list.
@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

PR #29003: Size comparison from 9db615b to 8bfc4b2

Decreases (1 build for efr32)
platform target config section 9db615b 8bfc4b2 change % change
efr32 lighting-app BRD4187C (read/write) 1079212 1079204 -8 -0.0
.text 889928 889920 -8 -0.0
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 9db615b 8bfc4b2 change % change
bl602 lighting-app bl602 (read/write) 1365550 1365550 0 0.0
.bss 73446 73446 0 0.0
.data 9600 9600 0 0.0
.text 1058510 1058510 0 0.0
bl602+rpc (read/write) 1412698 1412698 0 0.0
.bss 81486 81486 0 0.0
.data 9952 9952 0 0.0
.text 1090188 1090188 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1168659 1168659 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41301 41301 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 3584 3584 0 0.0
.debug_abbrev 1565736 1565736 0 0.0
.debug_aranges 137960 137960 0 0.0
.debug_frame 507324 507324 0 0.0
.debug_info 41819200 41819200 0 0.0
.debug_line 5449393 5449393 0 0.0
.debug_loc 3517421 3517421 0 0.0
.debug_ranges 380584 380584 0 0.0
.debug_str 3953257 3953257 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107136 107136 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 590829 590829 0 0.0
.symtab 176000 176000 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955666 955666 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1265475 1265475 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43248 43248 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1742556 1742556 0 0.0
.debug_aranges 146624 146624 0 0.0
.debug_frame 536576 536576 0 0.0
.debug_info 46722327 46722327 0 0.0
.debug_line 5858278 5858278 0 0.0
.debug_loc 3722712 3722712 0 0.0
.debug_ranges 406480 406480 0 0.0
.debug_str 4374722 4374722 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122008 122008 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 655000 655000 0 0.0
.symtab 195200 195200 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028116 1028116 0 0.0
bl706-eth (read/write) 1014788 1014788 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 25586 25586 0 0.0
.bss_psram 94415 94415 0 0.0
.comment 48 48 0 0.0
.data 3304 3304 0 0.0
.debug_abbrev 1114772 1114772 0 0.0
.debug_aranges 114256 114256 0 0.0
.debug_frame 424196 424196 0 0.0
.debug_info 23273450 23273450 0 0.0
.debug_line 4407595 4407595 0 0.0
.debug_loc 3015681 3015681 0 0.0
.debug_ranges 317384 317384 0 0.0
.debug_str 3525259 3525259 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 97332 97332 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 455888 455888 0 0.0
.symtab 138032 138032 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
773744 773744 0 0.0
bl706-wifi (read/write) 1086959 1086959 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 9981 9981 0 0.0
.bss_psram 95151 95151 0 0.0
.comment 48 48 0 0.0
.data 3624 3624 0 0.0
.debug_abbrev 1207633 1207633 0 0.0
.debug_aranges 118520 118520 0 0.0
.debug_frame 439640 439640 0 0.0
.debug_info 24438597 24438597 0 0.0
.debug_line 4628597 4628597 0 0.0
.debug_loc 3099727 3099727 0 0.0
.debug_ranges 326280 326280 0 0.0
.debug_str 3586660 3586660 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 1 1 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109608 109608 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 492653 492653 0 0.0
.symtab 150544 150544 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3402 3402 0 0.0
.text 0 0 0 0.0
847450 847450 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153892 1153892 0 0.0
.boot2 292 292 0 0.0
.bss 16004 16004 0 0.0
.bss_psram 77648 77648 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1568104 1568104 0 0.0
.debug_aranges 132480 132480 0 0.0
.debug_frame 487056 487056 0 0.0
.debug_info 41826005 41826005 0 0.0
.debug_line 5365600 5365600 0 0.0
.debug_loc 3453209 3453209 0 0.0
.debug_ranges 385904 385904 0 0.0
.debug_str 3965700 3965700 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 101000 101000 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 591023 591023 0 0.0
.symtab 175536 175536 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
944166 944166 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 735115 735115 0 0.0
(read/write) 166664 166664 0 0.0
.bss 89076 89076 0 0.0
.data 3424 3424 0 0.0
.rodata 84535 84535 0 0.0
.text 650192 650192 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 756435 756435 0 0.0
(read/write) 177056 177056 0 0.0
.bss 99436 99436 0 0.0
.data 3440 3440 0 0.0
.rodata 80015 80015 0 0.0
.text 676028 676028 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744339 744339 0 0.0
(read/write) 171528 171528 0 0.0
.bss 93908 93908 0 0.0
.data 3440 3440 0 0.0
.rodata 106263 106263 0 0.0
.text 637688 637688 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 694771 694771 0 0.0
(read/write) 165900 165900 0 0.0
.bss 88080 88080 0 0.0
.data 3412 3412 0 0.0
.rodata 80423 80423 0 0.0
.text 613956 613956 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 680339 680339 0 0.0
(read/write) 166032 166032 0 0.0
.bss 88224 88224 0 0.0
.data 3408 3408 0 0.0
.rodata 76263 76263 0 0.0
.text 603684 603684 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 617154 617154 0 0.0
(read/write) 207256 207256 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200696 200696 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 966877 966877 0 0.0
.debug_aranges 106760 106760 0 0.0
.debug_frame 361028 361028 0 0.0
.debug_info 21244759 21244759 0 0.0
.debug_line 2796659 2796659 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1567454 1567454 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 98959 98959 0 0.0
.debug_str 3368204 3368204 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106506 106506 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 499911 499911 0 0.0
.symtab 294208 294208 0 0.0
.text 508524 508524 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 553055 553055 0 0.0
.app_xip_area 444073 444073 0 0.0
.bss 63952 63952 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539511 539511 0 0.0
.app_xip_area 425593 425593 0 0.0
.bss 68856 68856 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574871 574871 0 0.0
.app_xip_area 467089 467089 0 0.0
.bss 62824 62824 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 559487 559487 0 0.0
.app_xip_area 448481 448481 0 0.0
.bss 65952 65952 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1026356 1026356 0 0.0
.bss 193028 193028 0 0.0
.data 2668 2668 0 0.0
.text 830640 830640 0 0.0
BRD4187C (read/write) 1079212 1079204 -8 -0.0
.bss 186008 186008 0 0.0
.data 3256 3256 0 0.0
.text 889928 889920 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1103092 1103092 0 0.0
.bss 186956 186956 0 0.0
.data 2684 2684 0 0.0
.text 913432 913432 0 0.0
window-app BRD4187C (read/write) 1128096 1128096 0 0.0
.bss 168768 168768 0 0.0
.data 3132 3132 0 0.0
.text 956176 956176 0 0.0
esp32 all-clusters-app c3devkit (read only) 1173002 1173002 0 0.0
(read/write) 1703892 1703892 0 0.0
.dram0.bss 79056 79056 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 268840 268840 0 0.0
.flash.text 1173002 1173002 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1214011 1214011 0 0.0
(read/write) 553370 553370 0 0.0
.dram0.bss 85672 85672 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 300044 300044 0 0.0
.flash.text 1208627 1208627 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 591068 591068 0 0.0
(read/write) 87944 87944 0 0.0
.bss 71192 71192 0 0.0
.data 2128 2128 0 0.0
.text 590532 590532 0 0.0
light k32w0+release (read only) 589852 589852 0 0.0
(read/write) 87596 87596 0 0.0
.bss 70856 70856 0 0.0
.data 2116 2116 0 0.0
.text 589316 589316 0 0.0
lock k32w0+release (read only) 562212 562212 0 0.0
(read/write) 85396 85396 0 0.0
.bss 68712 68712 0 0.0
.data 2060 2060 0 0.0
.text 561676 561676 0 0.0
linux all-clusters-app debug (read only) 5649017 5649017 0 0.0
(read/write) 420072 420072 0 0.0
.bss 130400 130400 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 278264 278264 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 339188 339188 0 0.0
.text 4928723 4928723 0 0.0
all-clusters-minimal-app debug (read only) 4915713 4915713 0 0.0
(read/write) 232360 232360 0 0.0
.bss 126336 126336 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 95024 95024 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272584 272584 0 0.0
.text 4412355 4412355 0 0.0
bridge-app debug (read only) 2772769 2772769 0 0.0
(read/write) 133144 133144 0 0.0
.bss 51768 51768 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71440 71440 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214536 214536 0 0.0
.text 2380563 2380563 0 0.0
chip-tool debug (read only) 10332689 10332689 0 0.0
(read/write) 441752 441752 0 0.0
.bss 93688 93688 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 335728 335728 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 388817 388817 0 0.0
.text 9348435 9348435 0 0.0
chip-tool-ipv6only arm64 (read only) 10174108 10174108 0 0.0
(read/write) 504184 504184 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 373080 373080 0 0.0
.dynamic 512 512 0 0.0
.got 18192 18192 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316184 316184 0 0.0
.text 9093992 9093992 0 0.0
lighting-app debug+rpc+ui (read only) 5246041 5246041 0 0.0
(read/write) 222504 222504 0 0.0
.bss 118032 118032 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92376 92376 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337268 337268 0 0.0
.text 4666339 4666339 0 0.0
lock-app debug (read only) 4479041 4479041 0 0.0
(read/write) 203096 203096 0 0.0
.bss 113456 113456 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 79080 79080 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248488 248488 0 0.0
.text 4021059 4021059 0 0.0
ota-provider-app debug (read only) 4130481 4130481 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113600 113600 0 0.0
.data 4032 4032 0 0.0
.data.rel.ro 68480 68480 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201160 201160 0 0.0
.text 3738883 3738883 0 0.0
ota-requestor-app debug (read only) 4223961 4223961 0 0.0
(read/write) 196344 196344 0 0.0
.bss 114656 114656 0 0.0
.data 4272 4272 0 0.0
.data.rel.ro 71480 71480 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204488 204488 0 0.0
.text 3824707 3824707 0 0.0
shell debug (read only) 3051041 3051041 0 0.0
(read/write) 153520 153520 0 0.0
.bss 60808 60808 0 0.0
.data 784 784 0 0.0
.data.rel.ro 85992 85992 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 214578 214578 0 0.0
.text 2661970 2661970 0 0.0
thermostat-no-ble arm64 (read only) 4358124 4358124 0 0.0
(read/write) 241896 241896 0 0.0
.bss 122200 122200 0 0.0
.data 2896 2896 0 0.0
.data.rel.ro 100512 100512 0 0.0
.dynamic 512 512 0 0.0
.got 11824 11824 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161268 161268 0 0.0
.text 3862792 3862792 0 0.0
tv-app debug (read only) 5321329 5321329 0 0.0
(read/write) 350824 350824 0 0.0
.bss 242016 242016 0 0.0
.data 5136 5136 0 0.0
.data.rel.ro 96256 96256 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 272952 272952 0 0.0
.text 4804323 4804323 0 0.0
tv-casting-app debug (read only) 8280057 8280057 0 0.0
(read/write) 211288 211288 0 0.0
.bss 54720 54720 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147224 147224 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 338428 338428 0 0.0
.text 7541123 7541123 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523272 2523272 0 0.0
.bss 219416 219416 0 0.0
.data 5128 5128 0 0.0
.text 1485956 1485956 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1240792 1240792 0 0.0
bss 155434 155434 0 0.0
rodata 143052 143052 0 0.0
text 863260 863260 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1359124 1359124 0 0.0
bss 140900 140900 0 0.0
rodata 136956 136956 0 0.0
text 790552 790552 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160840 1160840 0 0.0
bss 154836 154836 0 0.0
rodata 113748 113748 0 0.0
text 813312 813312 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837192 837192 0 0.0
(read/write) 1793596 1793596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193596 193596 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1418075 1418075 0 0.0
.debug_aranges 145128 145128 0 0.0
.debug_frame 482864 482864 0 0.0
.debug_info 33496399 33496399 0 0.0
.debug_line 4234073 4234073 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2303619 2303619 0 0.0
.debug_rnglists 144409 144409 0 0.0
.debug_str 4531015 4531015 0 0.0
.heap 837192 837192 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 851274 851274 0 0.0
.symtab 515280 515280 0 0.0
.text 1589060 1589060 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839944 839944 0 0.0
(read/write) 1678740 1678740 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190932 190932 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1290840 1290840 0 0.0
.debug_aranges 135040 135040 0 0.0
.debug_frame 454432 454432 0 0.0
.debug_info 29291296 29291296 0 0.0
.debug_line 3947790 3947790 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2120780 2120780 0 0.0
.debug_rnglists 134012 134012 0 0.0
.debug_str 3922454 3922454 0 0.0
.heap 839944 839944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 719966 719966 0 0.0
.symtab 467712 467712 0 0.0
.text 1476956 1476956 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846280 846280 0 0.0
(read/write) 1607052 1607052 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184708 184708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1130665 1130665 0 0.0
.debug_aranges 125136 125136 0 0.0
.debug_frame 417476 417476 0 0.0
.debug_info 24345318 24345318 0 0.0
.debug_line 3512227 3512227 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1957563 1957563 0 0.0
.debug_rnglists 123709 123709 0 0.0
.debug_str 3729697 3729697 0 0.0
.heap 846280 846280 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 637531 637531 0 0.0
.symtab 431248 431248 0 0.0
.text 1411604 1411604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818880 818880 0 0.0
(read/write) 1640340 1640340 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212092 212092 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1121629 1121629 0 0.0
.debug_aranges 123944 123944 0 0.0
.debug_frame 413128 413128 0 0.0
.debug_info 24157041 24157041 0 0.0
.debug_line 3465282 3465282 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1936082 1936082 0 0.0
.debug_rnglists 121805 121805 0 0.0
.debug_str 3693086 3693086 0 0.0
.heap 818880 818880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 611606 611606 0 0.0
.symtab 423296 423296 0 0.0
.text 1417492 1417492 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177908 1177908 0 0.0
.bss 101024 101024 0 0.0
.data 744 744 0 0.0
.text 624752 624752 0 0.0
lock-app qpg6105+debug (read/write) 1135396 1135396 0 0.0
.bss 95744 95744 0 0.0
.data 748 748 0 0.0
.text 582236 582236 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1095980 1095980 0 0.0
bss 108148 108148 0 0.0
text 752140 752140 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 981712 981712 0 0.0
bss 105332 105332 0 0.0
text 673700 673700 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944952 944952 0 0.0
bss 109652 109652 0 0.0
text 647600 647600 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876908 876908 0 0.0
bss 98696 98696 0 0.0
text 591120 591120 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 923252 923252 0 0.0
bss 99536 99536 0 0.0
text 632806 632806 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 984172 984172 0 0.0
bss 107504 107504 0 0.0
text 687268 687268 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 995536 995536 0 0.0
bss 111752 111752 0 0.0
text 694784 694784 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1053760 1053760 0 0.0
bss 109076 109076 0 0.0
text 732264 732264 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1086152 1086152 0 0.0
bss 120412 120412 0 0.0
text 752768 752768 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934972 934972 0 0.0
bss 99424 99424 0 0.0
text 622248 622248 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899512 899512 0 0.0
bss 100012 100012 0 0.0
text 612974 612974 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882332 882332 0 0.0
bss 98828 98828 0 0.0
text 596746 596746 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869464 869464 0 0.0
bss 98628 98628 0 0.0
text 587168 587168 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 745020 745020 0 0.0
bss 97468 97468 0 0.0
text 478820 478820 0 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 880408 880408 0 0.0
bss 98816 98816 0 0.0
text 595478 595478 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865644 865644 0 0.0
bss 98536 98536 0 0.0
text 582814 582814 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890920 890920 0 0.0
bss 98928 98928 0 0.0
text 602896 602896 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 886544 886544 0 0.0
bss 99252 99252 0 0.0
text 598220 598220 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit 08f00d5 into project-chip:master Sep 1, 2023
@bzbarsky-apple bzbarsky-apple deleted the address-review-comments branch September 1, 2023 01:12
abpoth pushed a commit to abpoth/connectedhomeip that referenced this pull request Sep 12, 2023
@bzbarsky-apple @abpoth
Address some review comments on Darwin controller data store. (projec…
2d3f007 
…t-chip#29003)

1) More efficient copying of arrays.
2) Make it clear what classes need to go in our storage class list.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@bzbarsky-apple @HunsupJung
Address some review comments on Darwin controller data store. (projec…
df4e077 
…t-chip#29003)

1) More efficient copying of arrays.
2) Make it clear what classes need to go in our storage class list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @ksperling-apple