-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRLK] Return NOT_FOUND error for non-existent User on GetWeekdaySchedule/GetYeardaySchedule commands #28974
Merged
mergify
merged 7 commits into
project-chip:master
from
jrhees-cae:drlk-sched-notfound-err
Sep 1, 2023
Merged
[DRLK] Return NOT_FOUND error for non-existent User on GetWeekdaySchedule/GetYeardaySchedule commands #28974
mergify
merged 7 commits into
project-chip:master
from
jrhees-cae:drlk-sched-notfound-err
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule/GetYeardaySchedule commands Fixes project-chip#21791
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
August 30, 2023 22:20
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 30, 2023 22:20
PR #28974: Size comparison from 42681a2 to 6b543e0 Increases (4 builds for cc32xx, psoc6)
Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28974: Size comparison from 42681a2 to 7268cdb Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #28974: Size comparison from 42681a2 to 2477ba8 Increases (7 builds for cc32xx, esp32, psoc6, telink)
Decreases (2 builds for efr32, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28974: Size comparison from 42681a2 to 4717aee Increases (10 builds for cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for efr32, linux, nrfconnect, psoc6, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 31, 2023
andy31415
approved these changes
Sep 1, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
…dule/GetYeardaySchedule commands (project-chip#28974) * [DRLK] Return NOT_FOUND error for non-existent User on GetWeekdaySchedule/GetYeardaySchedule commands Fixes project-chip#21791 * Restyled by prettier-yaml * zap-regen * Include changes to DL_Schedules.yaml test * zap regen * Fix issue with DL_Schedules for correct Status codes --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…dule/GetYeardaySchedule commands (project-chip#28974) * [DRLK] Return NOT_FOUND error for non-existent User on GetWeekdaySchedule/GetYeardaySchedule commands Fixes project-chip#21791 * Restyled by prettier-yaml * zap-regen * Include changes to DL_Schedules.yaml test * zap regen * Fix issue with DL_Schedules for correct Status codes --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRLK] Return NOT_FOUND error for non-existent User on GetWeekdaySchedule/GetYeardaySchedule commands
Fixes #21791
Corresponding spec updates: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7491
Corresponding test plan changes: https://github.com/CHIP-Specifications/chip-test-plans/pull/3395