[MatterYamlTests] Add basic support for darwin-framework-tool #28969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PR #28969: Size comparison from be58431 to 7c1176e Full report (21 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, qpg)
|
vivien-apple
force-pushed
the
MatterYamlTests_AddBasicSupportForDarwinFrameworkTool
branch
from
7c1176e to
5d38cb3
Compare
|
PR #28969: Size comparison from 98e3bc6 to 5d38cb3 Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
MatterYamlTests_AddBasicSupportForDarwinFrameworkTool
branch
from
5d38cb3 to
a88d3da
Compare
|
PR #28969: Size comparison from 3f7d03c to a88d3da Full report (9 builds for cc32xx, linux, mbed, nrfconnect, qpg)
|
tcarmelveilleux
approved these changes
Aug 31, 2023
|
I just pushed a small change such that |
vivien-apple
force-pushed
the
MatterYamlTests_AddBasicSupportForDarwinFrameworkTool
branch
from
a88d3da to
8043733
Compare
|
PR #28969: Size comparison from 3f7d03c to 8043733 Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
MatterYamlTests_AddBasicSupportForDarwinFrameworkTool
branch
from
8043733 to
d058fb0
Compare
|
PR #28969: Size comparison from ea3970a to d058fb0 Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Sep 6, 2023
…the moment darwin-framework-tool does not send back anything nor supports special test commands that have been added to chip-tool to fully support yaml
…adapter/encoder.py so it does use the right argument names for darwin-framework-tool
vivien-apple
force-pushed
the
MatterYamlTests_AddBasicSupportForDarwinFrameworkTool
branch
from
d058fb0 to
f876232
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple and
carol-apple
pullapprove
bot
requested review from
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
LuDuda,
mhazley,
nivi-apple,
p0fi,
plauric,
saurabhst,
sharadb-amazon,
tima-q,
tobiasgraf,
woody-apple and
younghak-hwang
|
PR #28969: Size comparison from 5867ac5 to f876232 Decreases (3 builds for bl602, efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
…t-chip#28969) * Add darwin-framework-tool python yaml parser connection support. For the moment darwin-framework-tool does not send back anything nor supports special test commands that have been added to chip-tool to fully support yaml * Add sleep command to darwin-framework-tool * Add wait-for-commissionee command to darwin-framework-tool * Add darwin-framework-tool python yaml parser output connection support * Hack examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/encoder.py so it does use the right argument names for darwin-framework-tool --------- Co-authored-by: Vivien Nicolas <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…t-chip#28969) * Add darwin-framework-tool python yaml parser connection support. For the moment darwin-framework-tool does not send back anything nor supports special test commands that have been added to chip-tool to fully support yaml * Add sleep command to darwin-framework-tool * Add wait-for-commissionee command to darwin-framework-tool * Add darwin-framework-tool python yaml parser output connection support * Hack examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/encoder.py so it does use the right argument names for darwin-framework-tool --------- Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
darwin-framework-toolis not compatible withmatter_yamltestsThis PR adds the basic infrastructure to get a large part of it working. By a large part I mean that only one test in
TestCluster.yamldoes not work properly (Read list of structs containing nullables and optionals after writing)Otherwise one can run something like
./scripts/tests/yaml/darwinframeworktool.py tests TestClustersimilarly to./scripts/tests/yaml/chiptool.py tests TestClusterThis is the first step to get move forward with the codegen tests of
darwin-framework-tool. More work is needed to get rid of codeine, such as running the same set of tests than codegen and observe what is missing.