-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Smoke CO Alarm Cluster SDK #28961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 30, 2023 05:14
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 30, 2023 05:14
PR #28961: Size comparison from 0eafac9 to 3a68f3f Increases (7 builds for esp32, nrfconnect, psoc6, telink)
Decreases (4 builds for efr32, linux, psoc6)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 30, 2023
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Aug 30, 2023
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
requested changes
Aug 30, 2023
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
PR #28961: Size comparison from 0eafac9 to ac7fe9d Increases above 0.2%:
Increases (22 builds for bl702, bl702l, cc13x4_26x4, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702, efr32, esp32, linux, nrfconnect, psoc6)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/clusters/smoke-co-alarm-server/smoke-co-alarm-server.cpp
Outdated
Show resolved
Hide resolved
ericzijian1994
force-pushed
the
fix-smokeco
branch
from
September 4, 2023 09:11
ac7fe9d
to
b1d255d
Compare
PR #28961: Size comparison from 54038c0 to b1d255d Increases (5 builds for esp32, nrfconnect, psoc6)
Decreases (2 builds for efr32, psoc6)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28961: Size comparison from 54038c0 to 16a0421 Increases (10 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ericzijian1994
force-pushed
the
fix-smokeco
branch
from
September 5, 2023 00:41
16a0421
to
9810c86
Compare
PR #28961: Size comparison from 54038c0 to 9810c86 Increases (10 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 8, 2023
mkardous-silabs
approved these changes
Sep 11, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Sep 12, 2023
* Remove redundant pics values * Avoid unsupported attributes affecting other --------- Co-authored-by: Hare <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Remove redundant pics values * Avoid unsupported attributes affecting other --------- Co-authored-by: Hare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unsupported attributes affecting other.
In PR Update SMOKECO SDK #28751, there is a change from "if success" to "VerifyOrReturn*".
However, if some optional attributes are disabled in zap, then SetDeviceMuted() or SetExpressedStateByPriority() may fail due to UNSUPPORTED_ATTRIBUTE.
With this change, SetDeviceMuted() and SetExpressedStateByPriority() will not exit with an UNSUPPORTED_ATTRIBUTE error.
Remove redundant pics values.
Remove accidentally added redundant pics values.