-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix esp32 platform bluedroid, should send indication instead of notification. #28923
Fix esp32 platform bluedroid, should send indication instead of notification. #28923
Conversation
…nstead of notification
PR #28923: Size comparison from 2d5fe2c to 053aad2 Decreases (3 builds for bl602, efr32, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@ryan-ma please sign the CLA |
PR #28923: Size comparison from 2d5fe2c to b996e37 Increases (31 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6, telink)
Decreases (18 builds for bl702, bl702l, cyw30739, k32w, linux, nrfconnect, qpg)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@ryan-ma Please fix the restyled issue? For example by applying this diff: https://restyled.io/gh/project-chip/repos/connectedhomeip/jobs/3496271/patch I tried to push a fix for it to your branch, but looks like that's not set up with access for Matter maintainers. |
@ryan-ma Restyler check in CI is failing. Please check |
…ication. (project-chip#28923) * Fix esp32 platform bluedroid implementation, should send indication instead of notification * Add comments * Restyled by clang-format --------- Co-authored-by: Ryan Ma <[email protected]>
…ication. (project-chip#28923) * Fix esp32 platform bluedroid implementation, should send indication instead of notification * Add comments * Restyled by clang-format --------- Co-authored-by: Ryan Ma <[email protected]>
We found some BLE commissioning issue using iOS16.5 or later.
We believe the root cause is the wrong
esp_ble_gatts_send_indicate
usage in the Bluedroid implementation.Form the esp-idf document.
We should use
true
to send indication.If the notification is used instead of indication, the commission may miss the notification packet causing commissioning failure. We see a high failure rate using iOS16.5.1 or later.
However, the bug is not easy to verify as the wrong implementation can pass validation in Test hardness.