Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync error code returning by SetTemperature command with spec #28910

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Sync error code returning by SetTemperature command with spec #28910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/app/clusters/temperature-control-server/temperature-control-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,13 @@ bool emberAfTemperatureControlClusterSetTemperatureCallback(app::CommandHandler
emberAfStatus = TemperatureSetpoint::Set(endpoint, targetTemperature.Value());
if (emberAfStatus != EMBER_ZCL_STATUS_SUCCESS)
{
status = app::ToInteractionModelStatus(emberAfStatus);
/**
* If the server is unable to execute the command at the time the command is received
* by the server (e.g. due to the design of a device it cannot accept a change in its
* temperature setting after it has begun operation), then the server SHALL respond
* with a status code of INVALID_IN_STATE, and discard the command.
**/
status = Status::InvalidInState;
}
}
else
Expand Down Expand Up @@ -200,7 +206,13 @@ bool emberAfTemperatureControlClusterSetTemperatureCallback(app::CommandHandler
emberAfStatus = SelectedTemperatureLevel::Set(endpoint, targetTemperatureLevel.Value());
if (emberAfStatus != EMBER_ZCL_STATUS_SUCCESS)
{
status = app::ToInteractionModelStatus(emberAfStatus);
/**
* If the server is unable to execute the command at the time the command is received
* by the server (e.g. due to the design of a device it cannot accept a change in its
* temperature setting after it has begun operation), then the server SHALL respond
* with a status code of INVALID_IN_STATE, and discard the command.
**/
status = Status::InvalidInState;
}
}
else
Expand Down