Make sure we handle BUSY responses during CASE properly. #28901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we got a BUSY response during a CASE handshake and successfully read the wait time, we would treat that as a success case, not a failure case, and not realize that our exchange has been closed. That could lead to use-after-free when we later tried to abort an already-closed exchange. The problem was introduced in 59a0b2f (PR project-chip#28153). The new unit test fails (both with ASAN failures and with incorrect state because the client that got BUSY does not think the handshake failed) without this fix.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple and
younghak-hwang
|
PR #28901: Size comparison from 79292ad to 8b09af7 Increases (12 builds for bl602, bl702, bl702l, cc32xx, psoc6)
Decreases (48 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 26, 2023
pidarped
reviewed
Aug 27, 2023
yufengwangca
approved these changes
Aug 28, 2023
pidarped
approved these changes
Aug 28, 2023
jtung-apple
approved these changes
Aug 29, 2023
saurabhst
approved these changes
Aug 29, 2023
|
Note: we do not need this on 1.1, because #28153 did not land there. |
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…p#28901) If we got a BUSY response during a CASE handshake and successfully read the wait time, we would treat that as a success case, not a failure case, and not realize that our exchange has been closed. That could lead to use-after-free when we later tried to abort an already-closed exchange. The problem was introduced in 59a0b2f (PR project-chip#28153). The new unit test fails (both with ASAN failures and with incorrect state because the client that got BUSY does not think the handshake failed) without this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we got a BUSY response during a CASE handshake and successfully read the wait time, we would treat that as a success case, not a failure case, and not realize that our exchange has been closed. That could lead to use-after-free when we later tried to abort an already-closed exchange.
The problem was introduced in 59a0b2f (PR #28153).
The new unit test fails (both with ASAN failures and with incorrect state because the client that got BUSY does not think the handshake failed) without this fix.