-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the label for the manual step of the TC-SMOKECO-2.4 #28876
Merged
mergify
merged 1 commit into
project-chip:master
from
ericzijian1994:change_smokeco_2_4_label
Aug 25, 2023
Merged
Modify the label for the manual step of the TC-SMOKECO-2.4 #28876
mergify
merged 1 commit into
project-chip:master
from
ericzijian1994:change_smokeco_2_4_label
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 25, 2023 01:19
pullapprove
bot
requested review from
mrjerryjohns,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 25, 2023 01:19
PR #28876: Size comparison from f23326b to a87ebfb Increases (1 build for telink)
Decreases (2 builds for bl602, efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 25, 2023
cecille
approved these changes
Aug 25, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Hare <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Co-authored-by: Hare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the label in step 37 to indicate when the self-test is triggered.
Situation
The Smoke CO self-test may require a longer time for a tester to engage the testing facility (e.g., Pressing and holding the test button) so the device can be put to the self-test. Such activity will be conducted during the DUT test from TC - SMOKECO.
The problem
Because the PR intending to response
waitForReport
YAML instruction is racy #19861 has yet to be merged, if a tester triggers the self-test at step 37 and then goes to step 38 after a longer period of time, it will cause step 38 to miss the report and lead to a test failure/wired waiting for the tester.This PR change is targeted to
The label modification is changed to encourage the user to wait until the waitForReport at the consequent step 38 starts, then do the manual DUT self-test.