-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -Wno-error=array-bounds
from several build configurations
#28835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
August 23, 2023 12:43
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 23, 2023 12:43
PR #28835: Size comparison from bd8c01f to 06f2afc Full report (12 builds for cc32xx, linux)
|
Marking as draft until I can update nlfaultinjection |
…patch for gcc12 support.
PR #28835: Size comparison from bd8c01f to a865b81 Decreases (1 build for efr32)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Aug 23, 2023
yufengwangca
approved these changes
Aug 23, 2023
PR #28835: Size comparison from bd8c01f to db99e21 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #28835: Size comparison from bd8c01f to 44dd9ec Increases above 0.2%:
Increases (5 builds for linux, nrfconnect, psoc6, telink)
Decreases (14 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28835: Size comparison from bd8c01f to 5e5d037 Increases above 0.2%:
Increases (10 builds for esp32, linux, nrfconnect, psoc6, telink)
Decreases (31 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6, qpg, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…roject-chip#28835) * Remove -Wno-error=array-bounds from nlfaultinjection library * Remove some array-bounds from esp32 as well: nlfaultinjection should be fixed separately * Remove nlfaultinjection as a submodule, add only relevant files with patch for gcc12 support. * Restyle * Update a few more include paths for nlfaultinjection * exclude nlfaultinjection from clangtidy * Restyle * Apply clang-tidy fixes to nlfaultinjection.cpp
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…roject-chip#28835) * Remove -Wno-error=array-bounds from nlfaultinjection library * Remove some array-bounds from esp32 as well: nlfaultinjection should be fixed separately * Remove nlfaultinjection as a submodule, add only relevant files with patch for gcc12 support. * Restyle * Update a few more include paths for nlfaultinjection * exclude nlfaultinjection from clangtidy * Restyle * Apply clang-tidy fixes to nlfaultinjection.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26133 introduced these because GCC 12 is more strict at detecting such errors that are intentional in nlfaultinjection.
Intent here is to fix nlfaultinjection only and not propagate the config throughout.
Changes:
Die
function to add ignore for array bound compile errors since we are intentionally invoking undefined behavior.