-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set Mode in each mode base clusters #28827
Merged
mergify
merged 3 commits into
project-chip:master
from
joonhaengHeo:add_set_mode_all_cluster_app
Aug 25, 2023
Merged
Add set Mode in each mode base clusters #28827
mergify
merged 3 commits into
project-chip:master
from
joonhaengHeo:add_set_mode_all_cluster_app
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
August 23, 2023 10:06
pullapprove
bot
requested review from
mkardous-silabs,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 23, 2023 10:06
PR #28827: Size comparison from 4e5cf29 to 8b1251b Increases (1 build for linux)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mhazley
approved these changes
Aug 25, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Add set Mode in each modebase clusters * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Add set Mode in each modebase clusters * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference test using all-cluster-app, all-cluster-app can't change mode.
(LaundryWasherMode, DishWasherMode, RvcRunMode, RvcCleanMode)
Example Test Case : TC-LWM-2.1, TC-DISHM-2.1 etc.
In this reason, I add "ChangeMode" trigger event in all-cluster-app.
After merged, we can change mode like below command.
echo '{"Name":"ModeChange","Device":"Dishwasher","Type":"Current","Mode":1}' > /tmp/chip_all_clusters_fifo_[PID