-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Change IdleModeInterval Type from milliseconds to seconds #28804
Merged
mkardous-silabs
merged 13 commits into
project-chip:master
from
mkardous-silabs:fix/idle_mode_interval
Aug 24, 2023
Merged
[ICD] Change IdleModeInterval Type from milliseconds to seconds #28804
mkardous-silabs
merged 13 commits into
project-chip:master
from
mkardous-silabs:fix/idle_mode_interval
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
lib
app
tests
core
icd
Intermittently Connected Devices
labels
Aug 22, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
August 22, 2023 14:32
PR #28804: Size comparison from 2b805b2 to a951047 Increases (31 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (7 builds for bl702, bl702l, cc32xx, psoc6)
Full report (31 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28804: Size comparison from 2b805b2 to 00e47e2 Increases (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (7 builds for bl702, bl702l, cc32xx, psoc6)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
mkardous-silabs
force-pushed
the
fix/idle_mode_interval
branch
from
August 22, 2023 20:33
00e47e2
to
100c17b
Compare
PR #28804: Size comparison from 6e12cb9 to 100c17b Increases (7 builds for bl602, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, cc32xx, efr32, esp32, k32w, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
force-pushed
the
fix/idle_mode_interval
branch
from
August 22, 2023 23:18
5b1c852
to
3bee8df
Compare
PR #28804: Size comparison from 684b9d6 to 3bee8df Full report (1 build for cc32xx)
|
mkardous-silabs
force-pushed
the
fix/idle_mode_interval
branch
from
August 22, 2023 23:36
234a71c
to
e1bfb69
Compare
PR #28804: Size comparison from 684b9d6 to e1bfb69 Increases (2 builds for telink)
Decreases (2 builds for efr32, esp32)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28804: Size comparison from 684b9d6 to 5d77f95 Increases above 0.2%:
Increases (14 builds for bl602, bl702, bl702l, linux, nrfconnect, psoc6, telink)
Decreases (30 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28804: Size comparison from 684b9d6 to 43d2ac0 Increases above 0.2%:
Increases (18 builds for bl602, bl702, bl702l, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (30 builds for bl602, bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…ect-chip#28804) * change idle mode interval type to seconds * generated files * Update silabs configurations * Fix unit tests with type change * Address review comments * restyle
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ect-chip#28804) * change idle mode interval type to seconds * generated files * Update silabs configurations * Fix unit tests with type change * Address review comments * restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
SDK update to change IdleModeInterval type from milliseconds to seconds.
Implements Spec and Test Plan changes
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7438
https://github.com/CHIP-Specifications/chip-test-plans/pull/3354