[ESP32] Enable LWIP_TCPIP_CORE_LOCKING by default and added static assert for the same #28798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when initializing route_hook
Static assert is disabled for ASR and bouffalolab platforms
shubhamdp
force-pushed
the
esp32_lwip_thread_safe
branch
from
a474ded to
ac45872
Compare
andy31415
approved these changes
Aug 22, 2023
dhrishi
approved these changes
Aug 24, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…sert for the same (project-chip#28798) * [ESP32] Enable LWIP_TCPIP_CORE_LOCKING by default and acquire lwip locks when initializing route_hook * inet: static assert if LWIP_TCPIP_CORE_LOCKING is disabled Static assert is disabled for ASR and bouffalolab platforms * typo
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…sert for the same (project-chip#28798) * [ESP32] Enable LWIP_TCPIP_CORE_LOCKING by default and acquire lwip locks when initializing route_hook * inet: static assert if LWIP_TCPIP_CORE_LOCKING is disabled Static assert is disabled for ASR and bouffalolab platforms * typo
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Feb 29, 2024
…sert for the same (project-chip#28798) * [ESP32] Enable LWIP_TCPIP_CORE_LOCKING by default and acquire lwip locks when initializing route_hook * inet: static assert if LWIP_TCPIP_CORE_LOCKING is disabled Static assert is disabled for ASR and bouffalolab platforms * typo
chshu
pushed a commit
that referenced
this pull request
Mar 12, 2024
* inet: ScopedLwIPLock for better safety and added locks at necessary places (#28655) * inet: scoped lwip locks for better safety and add at few more places * Do not static assert if LWIP_TCPIP_CORE_LOCKING is disabled * Add scope for locks * move out the error variable definition to the top * [ESP32] Enable LWIP_TCPIP_CORE_LOCKING by default and added static assert for the same (#28798) * [ESP32] Enable LWIP_TCPIP_CORE_LOCKING by default and acquire lwip locks when initializing route_hook * inet: static assert if LWIP_TCPIP_CORE_LOCKING is disabled Static assert is disabled for ASR and bouffalolab platforms * typo * UDPEndPointImplLwIP: Support LWIP_TCPIP_CORE_LOCKING=0 (#29057) Wrap calls to LwIP APIs in `tcpip_api_call()`, as required. When `LWIP_TCPIP_CORE_LOCKING` is enabled, this internally becomes `LOCK_TCPIP_CORE/UNLOCK_TCPIP_CORE` and when it isn't, it posts a message to the TCPIP task to run the function. Added CHIP stack locking to the UDP receive function. --------- Co-authored-by: Deomid Ryabkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28590 and followup for #28655
Change Overview
LWIP_TCPIP_CORE_LOCKINGby default and acquire lwip locks when initializing route_hookTests
Locally built the ESP32 lighting-app and tested commissioning and wildcard subscription.