-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: Set urgent before early returns #28793
Merged
mergify
merged 3 commits into
project-chip:master
from
cecille:python_subscription_isurgent
Aug 23, 2023
Merged
python: Set urgent before early returns #28793
mergify
merged 3 commits into
project-chip:master
from
cecille:python_subscription_isurgent
Aug 23, 2023
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
August 22, 2023 02:19
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
August 22, 2023 02:19
PR #28793: Size comparison from 270d8e2 to d1d4714 Increases (11 builds for bl602, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for bl702l, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Aug 22, 2023
We seem to get a:
|
PR #28793: Size comparison from 270d8e2 to 8c618d9 Increases above 0.2%:
Increases (15 builds for bl602, cyw30739, linux, psoc6, telink)
Decreases (17 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Aug 22, 2023
jrhees-cae
approved these changes
Aug 22, 2023
Note that this is somewhat related to #28817 |
TC-ACE-1.2 isn't setting isUrgent...but it COULD... |
jmartinez-silabs
approved these changes
Aug 22, 2023
Why use many line, when few line do trick.
PR #28793: Size comparison from 270d8e2 to fd7bcf2 Increases above 0.2%:
Increases (29 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (50 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Set urgent before early returns * Fix case where urgent isn't specified * pythonify this thing. Why use many line, when few line do trick.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Set urgent before early returns * Fix case where urgent isn't specified * pythonify this thing. Why use many line, when few line do trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly set isUrgent on python generated event subscriptions.
test: subscribed with isUrgent, can now see it being set
Fixes: #28567