[chip-tool] Remove codegen tests #28783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
tcarmelveilleux
approved these changes
Aug 21, 2023
vivien-apple
force-pushed
the
ChipTool_RemoveCodegen
branch
from
8e1d382 to
4e0fecf
Compare
cecille
approved these changes
Aug 21, 2023
|
PR #28783: Size comparison from fbc20e5 to 4e0fecf Increases (13 builds for k32w, psoc6, telink)
Decreases (8 builds for cc32xx, cyw30739, esp32, linux, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
requested changes
Aug 21, 2023
There was a problem hiding this comment.
Sorry, not a change request on this PR, but before this goes in, Vivien, can you confirm that there's a way for developers to run yaml tests against their own devices locally using the python runner? The run_test_suite.py script seems quite tied to the idea of having an app running locally
Sure. The drop in replacement for codegen version of
|
vivien-apple
force-pushed
the
ChipTool_RemoveCodegen
branch
from
4e0fecf to
aa78a9b
Compare
|
PR #28783: Size comparison from e8cb4ff to aa78a9b Increases (15 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Decreases (11 builds for bl602, esp32, linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
I get a bunch of errors when running that saying that it can't connect to the socket. Connecting to ws://localhost:9002 failed. Also a usage error for chip-tool. Is there something that needs to be done before to bootstrap it? I've built the python with the yaml tests enabled and am in the venv. Also, how do you pass through the config variables? |
You need to build
Did you mean "config variables" from the config section ? |
vivien-apple
force-pushed
the
ChipTool_RemoveCodegen
branch
from
aa78a9b to
09fe862
Compare
|
PR #28783: Size comparison from d0c47d2 to 09fe862 Increases (12 builds for bl602, bl702l, cyw30739, psoc6, telink)
Decreases (8 builds for esp32, linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
approved these changes
Aug 22, 2023
mkardous-silabs
approved these changes
Aug 22, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 24, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
Merged
This was referenced Sep 16, 2023
|
@vivien-apple The abov infos were helpful (after I found them ...). The very "hard coded way" for commands makes it very hard to use the new system ... the old one in chip-tool was much easier to utilize for other projects (we from https://github.com/project-chip/matter.js use the chip-tool tests in CI to make sure the library is compliant). While I understand the change and also see the benefits the PR misses to update any docs ... there still the old way is refernced (see also issue). I opened #29301 as "feature request" to at least make the "accessory bridge" configurable in order to be able to use it at all. Also on my macos development system whenever I run the test it asks me to allow chip-tool to accept incoming connections, but in fcat I allowed all build ones to o that ... no clue which executable it uses :-( DO you have any clue how to find that out? |
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR remove the codegen tests from
chip-tool.