-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align XML with spec - Update Color control revision #28763
Align XML with spec - Update Color control revision #28763
Conversation
PR #28763: Size comparison from 62155c8 to 4f53efa Increases (7 builds for bl702, bl702l, psoc6, telink)
Decreases (10 builds for cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question why this diff looks so big ?
@jmeg-sfy Some Zap file were not refreshed/updated in a long time. Zap version changes and name changes in XML are causing all those diff in zap files. |
4f53efa
to
521c24c
Compare
PR #28763: Size comparison from 39b4a77 to 521c24c Increases (12 builds for bl602, bl702l, cc32xx, cyw30739, psoc6, telink)
Decreases (13 builds for bl702, esp32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ate_cluster_revisions.py --cluster-id 0x0300 --new-revision 6 --old-revision 5
521c24c
to
836f0a5
Compare
PR #28763: Size comparison from 88a1d10 to 836f0a5 Increases (11 builds for bl602, cc32xx, cyw30739, nrfconnect, psoc6, telink)
Decreases (10 builds for psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Update colorcontrol cluster revision to 6, with scripts/tools/zap/update_cluster_revisions.py --cluster-id 0x0300 --new-revision 6 --old-revision 5 * run regen_all * rebase and fix conflicts * rebase and fix conflict 2
project-chip#28763 updated a bunch of ZAP files, and claimed it was fixing XML, but didn't fix the XML.
#28763 updated a bunch of ZAP files, and claimed it was fixing XML, but didn't fix the XML.
…p#29032) project-chip#28763 updated a bunch of ZAP files, and claimed it was fixing XML, but didn't fix the XML.
* Update colorcontrol cluster revision to 6, with scripts/tools/zap/update_cluster_revisions.py --cluster-id 0x0300 --new-revision 6 --old-revision 5 * run regen_all * rebase and fix conflicts * rebase and fix conflict 2
…p#29032) project-chip#28763 updated a bunch of ZAP files, and claimed it was fixing XML, but didn't fix the XML.
Fixes #26598
The spec revision added clarifications to Scenes support. No change to the implementation, scene must be fully implemented (targetted for 1.3)
This pr does
commit 1
Update colorcontrol cluster revision to 6, with scripts/tools/zap/update_cluster_revisions.py --cluster-id 0x0300 --new-revision 6 --old-revision 5
commit 2
scripts/tools/zap_regen_all.py