Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove Fabric ID negative value check #28724

Merged
merged 1 commit into from
Aug 21, 2023
Merged

[Android] Remove Fabric ID negative value check #28724

merged 1 commit into from
Aug 21, 2023

Conversation

joonhaengHeo
Copy link
Contributor

Fix #28696

Java long variable range is -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807.
uint64_t variable range is 0 to 18,446,744,073,709,551,615.

It would be best if there was an unsigned type in Java, but since it doesn't exist, you have no choice but to use negative values when using Java in your App.

For this reason, it has been modified to remove negative checks.

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

PR #28724: Size comparison from d0da504 to 260adf4

Increases (9 builds for cc32xx, esp32, psoc6, telink)
platform target config section d0da504 260adf4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19424243 19424244 1 0.0
esp32 all-clusters-app c3devkit (read only) 1151596 1151598 2 0.0
.flash.text 1151596 1151598 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 30267699 30267700 1 0.0
telink light-switch-app tlsr9518adk80d text 618570 618572 2 0.0
lighting-app-rpc tlsr9518adk80d (read/write) 1052716 1052724 8 0.0
text 731180 731182 2 0.0
lighting-app-shell tlsr9518adk80d (read/write) 1084260 1084268 8 0.0
text 751456 751458 2 0.0
pump-controller-app tlsr9518adk80d (read/write) 869424 869432 8 0.0
text 586904 586906 2 0.0
thermostat tlsr9518adk80d text 621926 621928 2 0.0
window-covering tlsr9518adk80d (read/write) 907284 907292 8 0.0
text 617236 617238 2 0.0
Decreases (9 builds for bl702, bl702l, efr32, psoc6, telink)
platform target config section d0da504 260adf4 change % change
bl702 lighting-app bl702+rpc .debug_info 46404537 46404536 -1 -0.0
.text 1029784 1029782 -2 -0.0
bl702l lighting-app bl702l (read/write) 1153836 1153832 -4 -0.0
.debug_info 41510939 41510937 -2 -0.0
.text 943854 943850 -4 -0.0
efr32 lighting-app BRD4187C (read/write) 1037316 1037308 -8 -0.0
.text 869940 869932 -8 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 2723475 27234750 -1 -0.0
telink bridge-app tlsr9518adk80d (read/write) 944896 944888 -8 -0.0
text 647450 647446 -4 -0.0
contact-sensor-app tlsr9518adk80d text 590840 590838 -2 -0.0
ota-requestor-app tlsr9518adk80d text 612682 612680 -2 -0.0
pump-app tlsr9518adk80d text 596444 596442 -2 -0.0
smoke_co_alarm-app tlsr9518adk80d text 594316 594314 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section d0da504 260adf4 change % change
bl602 lighting-app bl602 (read/write) 1365194 1365194 0 0.0
.bss 73622 73622 0 0.0
.data 9560 9560 0 0.0
.text 1057952 1057952 0 0.0
bl602+rpc (read/write) 1412662 1412662 0 0.0
.bss 81662 81662 0 0.0
.data 9952 9952 0 0.0
.text 1089886 1089886 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1168227 1168227 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43424 43424 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1567499 1567499 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 516608 516608 0 0.0
.debug_info 41509830 41509830 0 0.0
.debug_line 5485455 5485455 0 0.0
.debug_loc 3566483 3566483 0 0.0
.debug_ranges 384704 384704 0 0.0
.debug_str 4012504 4012504 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107196 107196 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589615 589615 0 0.0
.symtab 175792 175792 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
955102 955102 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1267159 1267159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43424 43424 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1744629 1744629 0 0.0
.debug_aranges 148936 148936 0 0.0
.debug_frame 545512 545512 0 0.0
.debug_info 46404537 46404536 -1 -0.0
.debug_line 5897977 5897977 0 0.0
.debug_loc 3772639 3772639 0 0.0
.debug_ranges 410456 410456 0 0.0
.debug_str 4432369 4432369 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121848 121848 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652578 652578 0 0.0
.symtab 194720 194720 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029784 1029782 -2 -0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1153836 1153832 -4 -0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77840 77840 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1569718 1569718 0 0.0
.debug_aranges 134896 134896 0 0.0
.debug_frame 496296 496296 0 0.0
.debug_info 41510939 41510937 -2 -0.0
.debug_line 5401149 5401149 0 0.0
.debug_loc 3502663 3502663 0 0.0
.debug_ranges 389912 389912 0 0.0
.debug_str 4024973 4024973 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 101080 101080 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589830 589830 0 0.0
.symtab 175344 175344 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
943854 943850 -4 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 616578 616578 0 0.0
(read/write) 207752 207752 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201192 201192 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 962128 962128 0 0.0
.debug_aranges 109072 109072 0 0.0
.debug_frame 369896 369896 0 0.0
.debug_info 19424243 19424244 1 0.0
.debug_line 2814570 2814570 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1597874 1597874 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100615 100615 0 0.0
.debug_str 3427592 3427592 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106602 106602 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 497700 497700 0 0.0
.symtab 293792 293792 0 0.0
.text 507852 507852 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 550735 550735 0 0.0
.app_xip_area 442025 442025 0 0.0
.bss 63728 63728 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 538159 538159 0 0.0
.app_xip_area 424393 424393 0 0.0
.bss 68760 68760 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574447 574447 0 0.0
.app_xip_area 466817 466817 0 0.0
.bss 62720 62720 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 549431 549431 0 0.0
.app_xip_area 438793 438793 0 0.0
.bss 65632 65632 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013076 1013076 0 0.0
.bss 184524 184524 0 0.0
.data 2652 2652 0 0.0
.text 825880 825880 0 0.0
BRD4187C (read/write) 1037316 1037308 -8 -0.0
.bss 164108 164108 0 0.0
.data 3248 3248 0 0.0
.text 869940 869932 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1090104 1090104 0 0.0
.bss 178588 178588 0 0.0
.data 2672 2672 0 0.0
.text 908824 908824 0 0.0
window-app BRD4187C (read/write) 1109120 1109120 0 0.0
.bss 147148 147148 0 0.0
.data 3132 3132 0 0.0
.text 958820 958820 0 0.0
esp32 all-clusters-app c3devkit (read only) 1151596 1151598 2 0.0
(read/write) 1702836 1702836 0 0.0
.dram0.bss 79120 79120 0 0.0
.dram0.data 13084 13084 0 0.0
.flash.rodata 266896 266896 0 0.0
.flash.text 1151596 1151598 2 0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1193255 1193255 0 0.0
(read/write) 551038 551038 0 0.0
.dram0.bss 85488 85488 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 297872 297872 0 0.0
.flash.text 1187871 1187871 0 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 591028 591028 0 0.0
(read/write) 88096 88096 0 0.0
.bss 71344 71344 0 0.0
.data 2128 2128 0 0.0
.text 590492 590492 0 0.0
light k32w0+release (read only) 589828 589828 0 0.0
(read/write) 87748 87748 0 0.0
.bss 71008 71008 0 0.0
.data 2116 2116 0 0.0
.text 589292 589292 0 0.0
lock k32w0+release (read only) 562180 562180 0 0.0
(read/write) 85548 85548 0 0.0
.bss 68864 68864 0 0.0
.data 2060 2060 0 0.0
.text 561644 561644 0 0.0
linux all-clusters-app debug (read only) 5519129 5519129 0 0.0
(read/write) 416760 416760 0 0.0
.bss 128704 128704 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 276712 276712 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1296 1296 0 0.0
.rodata 336176 336176 0 0.0
.text 4804867 4804867 0 0.0
all-clusters-minimal-app debug (read only) 4913873 4913873 0 0.0
(read/write) 231936 231936 0 0.0
.bss 126048 126048 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94896 94896 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272486 272486 0 0.0
.text 4410995 4410995 0 0.0
bridge-app debug (read only) 2770529 2770529 0 0.0
(read/write) 132848 132848 0 0.0
.bss 51512 51512 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71408 71408 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214600 214600 0 0.0
.text 2378403 2378403 0 0.0
chip-tool debug (read only) 17563729 17563729 0 0.0
(read/write) 1036096 1036096 0 0.0
.bss 93752 93752 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 929896 929896 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 907377 907377 0 0.0
.text 14646899 14646899 0 0.0
chip-tool-ipv6only arm64 (read only) 16786244 16786244 0 0.0
(read/write) 1103416 1103416 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 967272 967272 0 0.0
.dynamic 512 512 0 0.0
.got 23192 23192 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 819824 819824 0 0.0
.text 13772680 13772680 0 0.0
lighting-app debug+rpc+ui (read only) 5242193 5242193 0 0.0
(read/write) 222088 222088 0 0.0
.bss 117744 117744 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92248 92248 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 337108 337108 0 0.0
.text 4663011 4663011 0 0.0
lock-app debug (read only) 4475481 4475481 0 0.0
(read/write) 202936 202936 0 0.0
.bss 113360 113360 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 248102 248102 0 0.0
.text 4018003 4018003 0 0.0
ota-provider-app debug (read only) 4128249 4128249 0 0.0
(read/write) 191872 191872 0 0.0
.bss 113504 113504 0 0.0
.data 4000 4000 0 0.0
.data.rel.ro 68448 68448 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 201190 201190 0 0.0
.text 3736739 3736739 0 0.0
ota-requestor-app debug (read only) 4222161 4222161 0 0.0
(read/write) 196184 196184 0 0.0
.bss 114560 114560 0 0.0
.data 4240 4240 0 0.0
.data.rel.ro 71448 71448 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204582 204582 0 0.0
.text 3822931 3822931 0 0.0
shell debug (read only) 2939593 2939593 0 0.0
(read/write) 151040 151040 0 0.0
.bss 60008 60008 0 0.0
.data 784 784 0 0.0
.data.rel.ro 84376 84376 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 212562 212562 0 0.0
.text 2555922 2555922 0 0.0
thermostat-no-ble arm64 (read only) 4451652 4451652 0 0.0
(read/write) 243848 243848 0 0.0
.bss 122280 122280 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 102232 102232 0 0.0
.dynamic 512 512 0 0.0
.got 11984 11984 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 162236 162236 0 0.0
.text 3951336 3951336 0 0.0
tv-app debug (read only) 5317281 5317281 0 0.0
(read/write) 349856 349856 0 0.0
.bss 241280 241280 0 0.0
.data 5104 5104 0 0.0
.data.rel.ro 96048 96048 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272534 272534 0 0.0
.text 4801107 4801107 0 0.0
tv-casting-app debug (read only) 8296777 8296777 0 0.0
(read/write) 210576 210576 0 0.0
.bss 54208 54208 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147016 147016 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 367772 367772 0 0.0
.text 7528819 7528819 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522984 2522984 0 0.0
.bss 219920 219920 0 0.0
.data 5128 5128 0 0.0
.text 1485668 1485668 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1220976 1220976 0 0.0
bss 154642 154642 0 0.0
rodata 142036 142036 0 0.0
text 845248 845248 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1339108 1339108 0 0.0
bss 140100 140100 0 0.0
rodata 136028 136028 0 0.0
text 772284 772284 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160052 1160052 0 0.0
bss 154840 154840 0 0.0
rodata 113728 113728 0 0.0
text 812552 812552 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837664 837664 0 0.0
(read/write) 1769244 1769244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193140 193140 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2536 2536 0 0.0
.debug_abbrev 1382598 1382598 0 0.0
.debug_aranges 144024 144024 0 0.0
.debug_frame 479764 479764 0 0.0
.debug_info 30267699 30267700 1 0.0
.debug_line 4151557 4151557 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2251663 2251663 0 0.0
.debug_rnglists 142460 142460 0 0.0
.debug_str 4126558 4126558 0 0.0
.heap 837664 837664 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 806287 806287 0 0.0
.symtab 501840 501840 0 0.0
.text 0 0 0 0.0
1565180 1565180 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839600 839600 0 0.0
(read/write) 1678068 1678068 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191276 191276 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1285232 1285232 0 0.0
.debug_aranges 137240 137240 0 0.0
.debug_frame 462528 462528 0 0.0
.debug_info 2723475 27234750 -1 -0.0
.debug_line 3962212 3962212 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2150489 2150489 0 0.0
.debug_rnglists 135581 135581 0 0.0
.debug_str 3980749 3980749 0 0.0
.heap 839600 839600 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 717396 717396 0 0.0
.symtab 467296 467296 0 0.0
.text 1475940 1475940 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845912 845912 0 0.0
(read/write) 1606156 1606156 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185076 185076 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1125455 1125455 0 0.0
.debug_aranges 127336 127336 0 0.0
.debug_frame 425572 425572 0 0.0
.debug_info 22373280 22373280 0 0.0
.debug_line 3527053 3527053 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1986946 1986946 0 0.0
.debug_rnglists 125268 125268 0 0.0
.debug_str 3787686 3787686 0 0.0
.heap 845912 845912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 634730 634730 0 0.0
.symtab 430608 430608 0 0.0
.text 1410340 1410340 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818384 818384 0 0.0
(read/write) 1640180 1640180 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212588 212588 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1116919 1116919 0 0.0
.debug_aranges 126264 126264 0 0.0
.debug_frame 421636 421636 0 0.0
.debug_info 22287433 22287433 0 0.0
.debug_line 3482619 3482619 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1967512 1967512 0 0.0
.debug_rnglists 123469 123469 0 0.0
.debug_str 3752531 3752531 0 0.0
.heap 818384 818384 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 609601 609601 0 0.0
.symtab 423056 423056 0 0.0
.text 1416836 1416836 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178460 1178460 0 0.0
.bss 101176 101176 0 0.0
.data 744 744 0 0.0
.text 625304 625304 0 0.0
lock-app qpg6105+debug (read/write) 1135524 1135524 0 0.0
.bss 95896 95896 0 0.0
.data 748 748 0 0.0
.text 582364 582364 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1072844 1072844 0 0.0
bss 107336 107336 0 0.0
text 730926 730926 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 980564 980564 0 0.0
bss 105328 105328 0 0.0
text 672526 672526 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944896 944888 -8 -0.0
bss 109660 109660 0 0.0
text 647450 647446 -4 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876852 876852 0 0.0
bss 98840 98840 0 0.0
text 590840 590838 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 908156 908156 0 0.0
bss 99464 99464 0 0.0
text 618570 618572 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 983192 983192 0 0.0
bss 107516 107516 0 0.0
text 686250 686250 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 994556 994556 0 0.0
bss 111764 111764 0 0.0
text 693766 693766 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1052716 1052724 8 0.0
bss 109088 109088 0 0.0
text 731180 731182 2 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1084260 1084268 8 0.0
bss 120164 120164 0 0.0
text 751456 751458 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934844 934844 0 0.0
bss 99568 99568 0 0.0
text 621900 621900 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 899432 899432 0 0.0
bss 100148 100148 0 0.0
text 612682 612680 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882252 882252 0 0.0
bss 98972 98972 0 0.0
text 596444 596442 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 869424 869432 8 0.0
bss 98772 98772 0 0.0
text 586904 586906 2 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744420 744420 0 0.0
bss 97208 97208 0 0.0
text 478832 478832 0 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879460 879460 0 0.0
bss 98960 98960 0 0.0
text 594316 594314 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865604 865604 0 0.0
bss 98680 98680 0 0.0
text 582552 582552 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 911484 911484 0 0.0
bss 99224 99224 0 0.0
text 621926 621928 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 907284 907292 8 0.0
bss 99560 99560 0 0.0
text 617236 617238 2 0.0

@yufengwangca
Copy link
Contributor

our plan is to switch to kotlin to which has corresponding data type for uint64_t

@joonhaengHeo
Copy link
Contributor Author

our plan is to switch to kotlin to which has corresponding data type for uint64_t

I agree. However, the current issue has been reported, and I have already deleted and used this code due to the same issue.

@mergify mergify bot merged commit 5c7f8a6 into project-chip:master Aug 21, 2023
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@joonhaengHeo @HunsupJung
Remove Negative fabricId check (project-chip#28724)
a2c21ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Android matter sdk setFabricId does not accept values which touch twos compliment
5 participants
@joonhaengHeo @yufengwangca @saurabhst @yunhanw-google @jmartinez-silabs