[ICD] Report before idle mode #28714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28714: Size comparison from 39511c2 to 966dcef Increases (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Decreases (3 builds for bl702, bl702l)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
LuDuda
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
lpbeliveau-silabs
force-pushed
the
feature/icd_manager_check_report_before_sleep
branch
from
966dcef to
46a0f7a
Compare
|
PR #28714: Size comparison from ba875f9 to 46a0f7a Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, bl702l, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
reviewed
Aug 21, 2023
jmeg-sfy
reviewed
Aug 21, 2023
jmeg-sfy
approved these changes
Aug 21, 2023
jmartinez-silabs
approved these changes
Aug 21, 2023
…avoid the device waking up earlier
…ctive mode, Changed OnActiveModeAlmostDone to OnTransitionToIdle, added check to prevent wrap around when computing OnTransitionToIdle timeout
lpbeliveau-silabs
force-pushed
the
feature/icd_manager_check_report_before_sleep
branch
from
6a5de0a to
2b3e177
Compare
|
PR #28714: Size comparison from d0c47d2 to 2b3e177 Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc32xx, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Added a check before going to idle mode to emit a report if it would avoid the device waking up earlier * Added check to prevent looping when emiting a report before leaving active mode, Changed OnActiveModeAlmostDone to OnTransitionToIdle, added check to prevent wrap around when computing OnTransitionToIdle timeout * Moved boolean set to true to proper place * Set flag before calling observer method * Added stub in observer test function
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Added a check before going to idle mode to emit a report if it would avoid the device waking up earlier * Added check to prevent looping when emiting a report before leaving active mode, Changed OnActiveModeAlmostDone to OnTransitionToIdle, added check to prevent wrap around when computing OnTransitionToIdle timeout * Moved boolean set to true to proper place * Set flag before calling observer method * Added stub in observer test function
lpbeliveau-silabs
deleted the
feature/icd_manager_check_report_before_sleep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a timer that will trigger a report before entering idle mode to try to prevent entering active mode pre-emptively.