-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android]add missing json member for AttributeWriteRequest #28712
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/missing_write_json
Aug 16, 2023
Merged
[Android]add missing json member for AttributeWriteRequest #28712
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/missing_write_json
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/missing_write_json
branch
from
August 15, 2023 19:02
255051e
to
bbcf829
Compare
PR #28712: Size comparison from 39511c2 to bbcf829 Increases (1 build for bl702l)
Decreases (5 builds for bl602, bl702, cc32xx, k32w, nrfconnect)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
yunhanw-google
force-pushed
the
feature/missing_write_json
branch
2 times, most recently
from
August 15, 2023 19:59
e58b4d2
to
88ddbdd
Compare
PR #28712: Size comparison from ba875f9 to 88ddbdd Increases (3 builds for cyw30739, k32w, nrfconnect)
Decreases (8 builds for bl602, bl702, bl702l, psoc6)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
August 15, 2023 20:32
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple and
younghak-hwang
August 15, 2023 20:32
yunhanw-google
force-pushed
the
feature/missing_write_json
branch
from
August 15, 2023 21:19
88ddbdd
to
b24b178
Compare
src/controller/java/src/chip/devicecontroller/model/AttributeWriteRequest.java
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/InvokeElement.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/model/AttributeWriteRequest.java
Outdated
Show resolved
Hide resolved
PR #28712: Size comparison from b378def to b24b178 Increases (1 build for nrfconnect)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
yunhanw-google
force-pushed
the
feature/missing_write_json
branch
from
August 15, 2023 21:46
b24b178
to
3d2a9ee
Compare
PR #28712: Size comparison from b378def to 13f7b83 Increases (11 builds for bl602, cc32xx, cyw30739, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Aug 15, 2023
yunhanw-google
force-pushed
the
feature/missing_write_json
branch
2 times, most recently
from
August 16, 2023 04:40
62a4ec0
to
47fb385
Compare
PR #28712: Size comparison from cf6ad44 to 47fb385 Increases (4 builds for bl602, bl702l, cc32xx)
Decreases (1 build for bl702)
Full report (15 builds for bl602, bl702, bl702l, cc32xx, k32w, mbed, nrfconnect, qpg)
|
yunhanw-google
force-pushed
the
feature/missing_write_json
branch
from
August 16, 2023 05:17
47fb385
to
0d392c5
Compare
PR #28712: Size comparison from cf6ad44 to 0d392c5 Increases (10 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (11 builds for bl602, cyw30739, efr32, esp32, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
Aug 16, 2023
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to json member in InvokeElement from Android controller, we also need to add the json member for AttributeWriteRequest