-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing Scenes Cluster feature flags #28706
Merged
mergify
merged 1 commit into
project-chip:master
from
mpbreton:feature/Matter-2231/Scenes-implement-missing-feature-flags
Aug 17, 2023
Merged
Implement missing Scenes Cluster feature flags #28706
mergify
merged 1 commit into
project-chip:master
from
mpbreton:feature/Matter-2231/Scenes-implement-missing-feature-flags
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
August 15, 2023 14:27
pullapprove
bot
requested review from
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
August 15, 2023 14:27
mpbreton
force-pushed
the
feature/Matter-2231/Scenes-implement-missing-feature-flags
branch
from
August 15, 2023 20:54
39f4c81
to
1214247
Compare
PR #28706: Size comparison from ba875f9 to 1214247 Increases (16 builds for cc32xx, linux, nrfconnect, psoc6, telink)
Decreases (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, linux, mbed, psoc6, qpg, telink)
Full report (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mpbreton
force-pushed
the
feature/Matter-2231/Scenes-implement-missing-feature-flags
branch
from
August 16, 2023 13:45
1214247
to
3cecfc2
Compare
PR #28706: Size comparison from 71aa96f to 3cecfc2 Increases (18 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for bl702, bl702l, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
requested changes
Aug 17, 2023
Explicit, TableSize FabricScenes
mpbreton
force-pushed
the
feature/Matter-2231/Scenes-implement-missing-feature-flags
branch
from
August 17, 2023 17:04
3cecfc2
to
ccbb767
Compare
PR #28706: Size comparison from ae38472 to ccbb767 Increases (19 builds for bl702, bl702l, linux, psoc6, telink)
Decreases (11 builds for bl702, cc32xx, cyw30739, k32w, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
approved these changes
Aug 17, 2023
saurabhst
approved these changes
Aug 17, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Explicit, TableSize FabricScenes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing flags for
Explicit,
TableSize
FabricScenes
In the scenes Cluster
Fixes #28217
Add zap generation of the modified xml template